Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8269307: ProblemList java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java on win-x64 #136

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 24, 2021

A trivial fix to ProblemList java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java on win-x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269307: ProblemList java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java on win-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/136/head:pull/136
$ git checkout pull/136

Update a local copy of the PR:
$ git checkout pull/136
$ git pull https://git.openjdk.java.net/jdk17 pull/136/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 136

View PR using the GUI difftool:
$ git pr show -t 136

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/136.diff

…tionKeyTest/ButtonActionKeyTest.java on win-x64
@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add client

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review June 24, 2021 16:51
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 24, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269307: ProblemList java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java on win-x64

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2021
@dcubed-ojdk
Copy link
Member Author

@vidmik - Thanks for the fast review!

/integrate

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.java.net label Jun 24, 2021
@openjdk
Copy link

openjdk bot commented Jun 24, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk
Copy link

openjdk bot commented Jun 24, 2021

@dcubed-ojdk The label client is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • 2d
  • swing
  • hotspot-runtime
  • jmx
  • nio
  • build
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@dcubed-ojdk
Copy link
Member Author

/label add awt

@openjdk
Copy link

openjdk bot commented Jun 24, 2021

Going to push as commit 424cc50.

@openjdk openjdk bot closed this Jun 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2021
@openjdk
Copy link

openjdk bot commented Jun 24, 2021

@dcubed-ojdk Pushed as commit 424cc50.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jun 24, 2021

@dcubed-ojdk The command label can only be used in open pull requests.

@mlbridge
Copy link

mlbridge bot commented Jun 24, 2021

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8269307 branch June 24, 2021 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.java.net integrated Pull request has been integrated
2 participants