Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

JDK-8266269: Lookup::accessClass fails with IAE when accessing an arrayClass with a protected inner class as component class #137

Closed
wants to merge 3 commits into from

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Jun 24, 2021

Lookup::accessClass should determine the accessibility of the element type. An array class is accessible if and only if its element type is accessible.

This also fixes a spec bug to document @throws NullPointerException if the argument is null.

Please review the CSR:
https://bugs.openjdk.java.net/browse/JDK-8269312


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266269: Lookup::accessClass fails with IAE when accessing an arrayClass with a protected inner class as component class

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/137/head:pull/137
$ git checkout pull/137

Update a local copy of the PR:
$ git checkout pull/137
$ git pull https://git.openjdk.java.net/jdk17 pull/137/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 137

View PR using the GUI difftool:
$ git pr show -t 137

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/137.diff

…ayClass with a protected inner class as component class
@mlchung
Copy link
Member Author

mlchung commented Jun 24, 2021

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jun 24, 2021
@openjdk
Copy link

openjdk bot commented Jun 24, 2021

@mlchung this pull request will not be integrated until the CSR request JDK-8269312 for issue JDK-8266269 has been approved.

@openjdk
Copy link

openjdk bot commented Jun 24, 2021

@mlchung The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.java.net label Jun 24, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 24, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2021

Webrevs

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jun 25, 2021
@openjdk
Copy link

openjdk bot commented Jun 25, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266269: Lookup::accessClass fails with IAE when accessing an arrayClass with a protected inner class as component class

Reviewed-by: chegar, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • 3d0d27c: 8269351: Proxy::newProxyInstance and MethodHandleProxies::asInterfaceInstance should reject sealed interfaces
  • 824a516: 8269260: Add AVX512 and other SSE + AVX combinations testing for tests which generate vector instructions
  • 1404e4b: 8269302: serviceability/dcmd/framework/InvalidCommandTest.java still fails after JDK-8268433
  • fb0a95f: 8269036: tools/jpackage/share/AppImagePackageTest.java failed with "hdiutil: create failed - Resource busy"
  • 5ebed06: 8269074: (fs) Files.copy fails to copy from /proc on some linux kernel versions
  • d799563: 8256919: BCEL: Utility.encode forget to close
  • 1e3b418: 8269335: Unable to load svml library
  • 4eb3212: 8268871: Adjust javac to updated exhaustiveness specification
  • 44691cc: 8268972: Add default impl for recent new Reporter.print method
  • 7ab1285: 8267610: NPE at at jdk.compiler/com.sun.tools.javac.jvm.Code.emitop
  • ... and 27 more: https://git.openjdk.java.net/jdk17/compare/d3ad8cd344681fe8442f821f97f05996bb972abe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 25, 2021
Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. In passing I think t8150782 is the only test directory using that naming convention. There are several tests using in the directory name.

@mlchung
Copy link
Member Author

mlchung commented Jun 26, 2021

I also notice that t8150782 outliner. It'd actually prefer to remove the directory t8150782 or place the tests in a directory name with descriptive name. That can be cleaned up as a separate issue.

@mlchung
Copy link
Member Author

mlchung commented Jun 26, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jun 26, 2021

Going to push as commit 6eb734a.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 3d0d27c: 8269351: Proxy::newProxyInstance and MethodHandleProxies::asInterfaceInstance should reject sealed interfaces
  • 824a516: 8269260: Add AVX512 and other SSE + AVX combinations testing for tests which generate vector instructions
  • 1404e4b: 8269302: serviceability/dcmd/framework/InvalidCommandTest.java still fails after JDK-8268433
  • fb0a95f: 8269036: tools/jpackage/share/AppImagePackageTest.java failed with "hdiutil: create failed - Resource busy"
  • 5ebed06: 8269074: (fs) Files.copy fails to copy from /proc on some linux kernel versions
  • d799563: 8256919: BCEL: Utility.encode forget to close
  • 1e3b418: 8269335: Unable to load svml library
  • 4eb3212: 8268871: Adjust javac to updated exhaustiveness specification
  • 44691cc: 8268972: Add default impl for recent new Reporter.print method
  • 7ab1285: 8267610: NPE at at jdk.compiler/com.sun.tools.javac.jvm.Code.emitop
  • ... and 27 more: https://git.openjdk.java.net/jdk17/compare/d3ad8cd344681fe8442f821f97f05996bb972abe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Jun 26, 2021
@openjdk
Copy link

openjdk bot commented Jun 26, 2021

@mlchung Pushed as commit 6eb734a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.java.net integrated Pull request has been integrated
3 participants