Skip to content
This repository has been archived by the owner. It is now read-only.

8256919: BCEL: Utility.encode forget to close #141

Closed
wants to merge 2 commits into from

Conversation

@JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Jun 24, 2021

Fix a regression caused by the previous BCEL update. The issue was fixed in the current BCEL repo with a reversal of the previous code, adding back "gos.close();". Note however, doing so will result in a warning: [try] explicit call to close() on an auto-closeable resource. This fix calls finish() instead.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/141/head:pull/141
$ git checkout pull/141

Update a local copy of the PR:
$ git checkout pull/141
$ git pull https://git.openjdk.java.net/jdk17 pull/141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 141

View PR using the GUI difftool:
$ git pr show -t 141

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/141.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 24, 2021

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

@JoeWang-Java The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Jun 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 24, 2021

Webrevs

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Looks OK to me

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256919: BCEL: Utility.encode forget to close

Reviewed-by: lancea, bpb, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • cfa6a99: 8269316: ProblemList vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java on Linux-X64 -Xcomp
  • 22d8675: 8269315: ProblemList javax/swing/JFileChooser/FileSystemView/SystemIconTest.java on Win-X64
  • 443a79a: 8269314: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Win-X64 and linux-aarch64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 24, 2021
bplb
bplb approved these changes Jun 24, 2021
Copy link
Member

@bplb bplb left a comment

+1

Copy link
Member

@naotoj naotoj left a comment

@Last Modified: needs to be updated. Otherwise looks good.

@JoeWang-Java
Copy link
Member Author

@JoeWang-Java JoeWang-Java commented Jun 24, 2021

Thanks Naoto, updated. Thanks Lance and Brian for the quick review!

naotoj
naotoj approved these changes Jun 24, 2021
@JoeWang-Java
Copy link
Member Author

@JoeWang-Java JoeWang-Java commented Jun 25, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2021

Going to push as commit d799563.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 1e3b418: 8269335: Unable to load svml library
  • 4eb3212: 8268871: Adjust javac to updated exhaustiveness specification
  • 44691cc: 8268972: Add default impl for recent new Reporter.print method
  • 7ab1285: 8267610: NPE at at jdk.compiler/com.sun.tools.javac.jvm.Code.emitop
  • cfa6a99: 8269316: ProblemList vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java on Linux-X64 -Xcomp
  • 22d8675: 8269315: ProblemList javax/swing/JFileChooser/FileSystemView/SystemIconTest.java on Win-X64
  • 443a79a: 8269314: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Win-X64 and linux-aarch64

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2021

@JoeWang-Java Pushed as commit d799563.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JoeWang-Java JoeWang-Java deleted the JDK-8256919 branch Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants