JDK-8269351: Proxy::newProxyInstance and MethodHandleProxies::asInterfaceInstance should reject sealed interfaces

[mlchung]

java.lang.reflect.Proxy::newProxyInstance and java.lang.invoke.MethodHandleProxies::asInterfaceInstance do not specify how to deal with sealed interfaces. These APIs should reject sealed interface with IllegalArgumentException which is thrown if the given interface is invalid.

Please review CSR:
https://bugs.openjdk.java.net/browse/JDK-8269396

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269351: Proxy::newProxyInstance and MethodHandleProxies::asInterfaceInstance should reject sealed interfaces

Reviewers

• Joe Darcy (@jddarcy - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/148/head:pull/148
$ git checkout pull/148

Update a local copy of the PR:
$ git checkout pull/148
$ git pull https://git.openjdk.java.net/jdk17 pull/148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 148

View PR using the GUI difftool:
$ git pr show -t 148

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/148.diff

[bridgekeeper]

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mlchung The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (466183ce)

[mlchung]

/csr

[openjdk]

@mlchung this pull request will not be integrated until the CSR request JDK-8269396 for issue JDK-8269351 has been approved.

[openjdk]

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269351: Proxy::newProxyInstance and MethodHandleProxies::asInterfaceInstance should reject sealed interfaces

Reviewed-by: darcy, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 824a516: 8269260: Add AVX512 and other SSE + AVX combinations testing for tests which generate vector instructions
• 1404e4b: 8269302: serviceability/dcmd/framework/InvalidCommandTest.java still fails after JDK-8268433
• fb0a95f: 8269036: tools/jpackage/share/AppImagePackageTest.java failed with "hdiutil: create failed - Resource busy"
• 5ebed06: 8269074: (fs) Files.copy fails to copy from /proc on some linux kernel versions
• d799563: 8256919: BCEL: Utility.encode forget to close
• 1e3b418: 8269335: Unable to load svml library

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlchung]

/integrate

[openjdk]

Going to push as commit 3d0d27c.
Since your change was applied there have been 6 commits pushed to the master branch:

• 824a516: 8269260: Add AVX512 and other SSE + AVX combinations testing for tests which generate vector instructions
• 1404e4b: 8269302: serviceability/dcmd/framework/InvalidCommandTest.java still fails after JDK-8268433
• fb0a95f: 8269036: tools/jpackage/share/AppImagePackageTest.java failed with "hdiutil: create failed - Resource busy"
• 5ebed06: 8269074: (fs) Files.copy fails to copy from /proc on some linux kernel versions
• d799563: 8256919: BCEL: Utility.encode forget to close
• 1e3b418: 8269335: Unable to load svml library

Your commit was automatically rebased without conflicts.

[openjdk]

@mlchung Pushed as commit 3d0d27c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.