8269302: serviceability/dcmd/framework/InvalidCommandTest.java still fails after JDK-8268433

[alexmenkov]

Please review this simple test fix for jdk17.

The cycle should run until connection is established (connection.isConnected() returns true) or error occurred (error != null)
This wrong condition causes test error if ListenerThread.getConnection() reaches "synchronized (this)" section earlier than ListenerThread.run()

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269302: serviceability/dcmd/framework/InvalidCommandTest.java still fails after JDK-8268433

Reviewers

• Kevin Walls (@kevinjwalls - Committer)
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/150/head:pull/150
$ git checkout pull/150

Update a local copy of the PR:
$ git checkout pull/150
$ git pull https://git.openjdk.java.net/jdk17 pull/150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 150

View PR using the GUI difftool:
$ git pr show -t 150

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/150.diff

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (87712ab9)

[dcubed-ojdk]

Thumbs up.

This looks like a trivial fix to me. I don't see any mention of
testing. It looks like the two tests mentioned in the bug both
run in Tier1 on multiple platforms.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269302: serviceability/dcmd/framework/InvalidCommandTest.java still fails after JDK-8268433

Reviewed-by: kevinw, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 5ebed06: 8269074: (fs) Files.copy fails to copy from /proc on some linux kernel versions
• d799563: 8256919: BCEL: Utility.encode forget to close
• 1e3b418: 8269335: Unable to load svml library

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexmenkov]

Thumbs up.

This looks like a trivial fix to me. I don't see any mention of
testing. It looks like the two tests mentioned in the bug both
run in Tier1 on multiple platforms.

Run 3 tests in test/hotspot/jtreg/serviceability/dcmd/framework 200 times (win and win-debug).
No failures.

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 1404e4b.
Since your change was applied there have been 4 commits pushed to the master branch:

• fb0a95f: 8269036: tools/jpackage/share/AppImagePackageTest.java failed with "hdiutil: create failed - Resource busy"
• 5ebed06: 8269074: (fs) Files.copy fails to copy from /proc on some linux kernel versions
• d799563: 8256919: BCEL: Utility.encode forget to close
• 1e3b418: 8269335: Unable to load svml library

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 1404e4b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.