Skip to content
This repository has been archived by the owner. It is now read-only.

8258746: illegal access to global field _jvmci_old_thread_counters by terminated thread causes crash #154

Closed
wants to merge 1 commit into from

Conversation

dean-long
Copy link
Member

@dean-long dean-long commented Jun 26, 2021

This change moves the access to the global field _jvmci_old_thread_counters from the thread destructor to JavaThread::exit(). See the JBS issue for more details. The free of _jvmci_counters is left in the destructor intentionally, as it is allocated in the JavaThread constructor and not all termination paths go through JavaThread::exit().


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258746: illegal access to global field _jvmci_old_thread_counters by terminated thread causes crash

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/154/head:pull/154
$ git checkout pull/154

Update a local copy of the PR:
$ git checkout pull/154
$ git pull https://git.openjdk.java.net/jdk17 pull/154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 154

View PR using the GUI difftool:
$ git pr show -t 154

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/154.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 26, 2021

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 26, 2021

@dean-long The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Jun 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 26, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Dean,

This looks good to me. :)

Good catch on keeping the free of _jvmci_counters in the destructor.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Jun 26, 2021

@dean-long This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258746: illegal access to global field _jvmci_old_thread_counters by terminated thread causes crash

Reviewed-by: dholmes, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 26, 2021
@dean-long
Copy link
Member Author

@dean-long dean-long commented Jun 26, 2021

Thanks, David and Vladimir.

@dean-long
Copy link
Member Author

@dean-long dean-long commented Jun 26, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 26, 2021

Going to push as commit d9cb068.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 6eb734a: 8266269: Lookup::accessClass fails with IAE when accessing an arrayClass with a protected inner class as component class
  • 3d0d27c: 8269351: Proxy::newProxyInstance and MethodHandleProxies::asInterfaceInstance should reject sealed interfaces

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 26, 2021

@dean-long Pushed as commit d9cb068.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dean-long dean-long deleted the JDK-8258746 branch Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-runtime integrated
3 participants