Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.

JDK-8268236 The documentation of the String.regionMatches method contains error #157

Closed
wants to merge 1 commit into from

Conversation

JimLaskey
Copy link
Member

@JimLaskey JimLaskey commented Jun 28, 2021

The documentation of the String.regionMatches method contains this fragment: this.substring(toffset, len).codePoints(), but String.substring method takes index, not the length, as the second argument.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268236: The documentation of the String.regionMatches method contains error

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/157/head:pull/157
$ git checkout pull/157

Update a local copy of the PR:
$ git checkout pull/157
$ git pull https://git.openjdk.java.net/jdk17 pull/157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 157

View PR using the GUI difftool:
$ git pr show -t 157

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/157.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2021

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 28, 2021
@openjdk
Copy link

openjdk bot commented Jun 28, 2021

@JimLaskey The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.java.net label Jun 28, 2021
@JimLaskey
Copy link
Member Author

/csr

@openjdk
Copy link

openjdk bot commented Jun 28, 2021

@JimLaskey the issue for this pull request, JDK-8268236, already has an approved CSR request: JDK-8268674

@mlbridge
Copy link

mlbridge bot commented Jun 28, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 28, 2021

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268236: The documentation of the String.regionMatches method contains error

Reviewed-by: rriggs, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 28, 2021
@JimLaskey
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 28, 2021

Going to push as commit e4c5446.

@openjdk openjdk bot closed this Jun 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 28, 2021
@openjdk
Copy link

openjdk bot commented Jun 28, 2021

@JimLaskey Pushed as commit e4c5446.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.java.net integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants