Skip to content
This repository has been archived by the owner. It is now read-only.

8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build #160

Closed
wants to merge 2 commits into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 28, 2021

Exclude test on Windows if VM is from a debug build.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/160/head:pull/160
$ git checkout pull/160

Update a local copy of the PR:
$ git checkout pull/160
$ git pull https://git.openjdk.java.net/jdk17 pull/160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 160

View PR using the GUI difftool:
$ git pr show -t 160

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/160.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 28, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

@RealCLanger The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing label Jun 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 28, 2021

Webrevs

mrserb
mrserb approved these changes Jun 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build

Reviewed-by: serb, psadhukhan, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • fc0fd96: 8269126: Rename G1AllowPreventiveGC option to G1UsePreventiveGC
  • 5624069: 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass
  • 09bb846: 8267952: async logging supports to dynamically change tags and decorators
  • 20640a5: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt
  • efe8423: 8269403: Fix jpackage tests to gracefully handle jpackage app launcher crashes
  • 8d09596: 8269304: Regression ~5% in 2005 in b27

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 28, 2021
Copy link
Contributor

@prsadhuk prsadhuk left a comment

looks ok. It will be good to update the copyright date too...

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jun 29, 2021

looks ok. It will be good to update the copyright date too...

You're right, thanks for the hint... updated.

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jun 29, 2021

Thanks for the reviews.

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jun 29, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

Going to push as commit d042029.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 401cb0a: 8269232: assert(!is_jweak(handle)) failed: wrong method for detroying jweak
  • b8a16e9: 8268884: C2: Compile::remove_speculative_types must iterate top-down
  • 25f9f19: 8249646: Runtime.exec(String, String[], File) documentation contains literal {@link ...}
  • 0d83dc2: 8268699: Shenandoah: Add test for JDK-8268127
  • 7010dfd: 8269517: compiler/loopopts/TestPartialPeelingSinkNodes.java crashes with -XX:+VerifyGraphEdges
  • fc0fd96: 8269126: Rename G1AllowPreventiveGC option to G1UsePreventiveGC
  • 5624069: 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass
  • 09bb846: 8267952: async logging supports to dynamically change tags and decorators
  • 20640a5: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt
  • efe8423: 8269403: Fix jpackage tests to gracefully handle jpackage app launcher crashes
  • ... and 1 more: https://git.openjdk.java.net/jdk17/compare/e4c5446340605b112e0918fa9dcb48aaeaa730c8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@RealCLanger Pushed as commit d042029.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the 8269529 branch Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated swing
4 participants