Skip to content
This repository has been archived by the owner. It is now read-only.

JDK-8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass #162

Closed
wants to merge 2 commits into from

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Jun 28, 2021

test/jdk/java/lang/invoke/t8150782 is the only one using that convention. There are several tests under <bugid> directory. As the tests under test/jdk/java/lang/invoke/t8150782 are mostly unit tests for Lookup::accessClass and Lookup::findClass, they can simply be moved to the parent directory.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/162/head:pull/162
$ git checkout pull/162

Update a local copy of the PR:
$ git checkout pull/162
$ git pull https://git.openjdk.java.net/jdk17 pull/162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 162

View PR using the GUI difftool:
$ git pr show -t 162

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/162.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 28, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

@mlchung The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Jun 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 28, 2021

Webrevs

@JornVernee
Copy link
Member

@JornVernee JornVernee commented Jun 28, 2021

Hi Mandy,

It looks like the test in question has some test support files associated with it (p/Foo.java & q/Bar.java). I personally think it's nice if tests like these are in a separate directory, so that it's easier to see which test support files belong to which test (and to avoid potential name clashes when 2 tests want to use a support file with the same name).

How would you feel about dropping just the t prefix from the test directory & package names? Then it would match the existing tests in <bugid> directories.

@mlchung
Copy link
Member Author

@mlchung mlchung commented Jun 28, 2021

That's a fair point. I personally prefer using a descriptive directory name rather than bug ID since that can give the reader what the tests are intended for. What about renaming t8150782 to accessClassAndFindClass?

@JornVernee
Copy link
Member

@JornVernee JornVernee commented Jun 28, 2021

That's a fair point. I personally prefer using a descriptive directory name rather than bug ID since that can give the reader what the tests are intended for. What about renaming t8150782 to accessClassAndFindClass?

Me too! That sounds like an excellent idea :)

@mlchung mlchung changed the title JDK-8269426: Move tests from test/jdk/java/lang/invoke/t8150782 to its parent directory JDK-8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass Jun 28, 2021
@mlchung
Copy link
Member Author

@mlchung mlchung commented Jun 28, 2021

Thanks Jorn.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 09bb846: 8267952: async logging supports to dynamically change tags and decorators
  • 20640a5: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt
  • efe8423: 8269403: Fix jpackage tests to gracefully handle jpackage app launcher crashes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 28, 2021
@mlchung
Copy link
Member Author

@mlchung mlchung commented Jun 28, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

Going to push as commit 5624069.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 09bb846: 8267952: async logging supports to dynamically change tags and decorators
  • 20640a5: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt
  • efe8423: 8269403: Fix jpackage tests to gracefully handle jpackage app launcher crashes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

@mlchung Pushed as commit 5624069.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs integrated
2 participants