8269594: assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark

[zhengyu123]

I would like to fix this assertion in jdk17. It was caught in Shenandoah nightly test and hard to reproduce, but fix is simple and low risk.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269594: assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• Jorn Vernee (@JornVernee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/173/head:pull/173
$ git checkout pull/173

Update a local copy of the PR:
$ git checkout pull/173
$ git pull https://git.openjdk.java.net/jdk17 pull/173/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 173

View PR using the GUI difftool:
$ git pr show -t 173

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/173.diff

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zhengyu123 The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a1839b00)

[coleenp]

This looks good. I think it's worth fixing because the Handles could leak without this assert in production, and that could be really hard to diagnose.

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269594: assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark

Reviewed-by: coleenp, jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 401cb0a: 8269232: assert(!is_jweak(handle)) failed: wrong method for detroying jweak
• b8a16e9: 8268884: C2: Compile::remove_speculative_types must iterate top-down
• 25f9f19: 8249646: Runtime.exec(String, String[], File) documentation contains literal {@link ...}
• 0d83dc2: 8268699: Shenandoah: Add test for JDK-8268127

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[JornVernee]

Looks good to me as well. I also ran into this assert while working on #149 [1] (when testing with ZGC)

[1] : https://github.com/openjdk/jdk17/pull/149/files#diff-d61020d12394708828d066d097d823180c01b74d35d4c3e369aead062abc11efR931

[zhengyu123]

@coleenp @JornVernee Thanks!

[zhengyu123]

/integrate

[openjdk]

Going to push as commit 4b4bef4.
Since your change was applied there have been 12 commits pushed to the master branch:

• 4ee400a: 8268320: Better error recovery for broken patterns in switch
• ca283c3: 8265907: JVM crashes when matching VectorMaskCmp Node
• c3c9189: 8269141: Switch statement containing pattern case label element gets in the loop during execution
• 6b64a79: 8268350: Remove assert that ensures thread identifier remains the same
• 90eb118: 8269528: VectorAPI Long512VectorTest fails on X86 KNL target
• a661686: 8269065: [REDO] vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java failed with OutOfMemoryError
• 0d745ae: 8269034: AccessControlException for SunPKCS11 daemon threads
• d042029: 8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build
• 401cb0a: 8269232: assert(!is_jweak(handle)) failed: wrong method for detroying jweak
• b8a16e9: 8268884: C2: Compile::remove_speculative_types must iterate top-down
• ... and 2 more: https://git.openjdk.java.net/jdk17/compare/7010dfdffab3582d7f5e935247735dff1b3152e6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@zhengyu123 Pushed as commit 4b4bef4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.