Skip to content
This repository has been archived by the owner. It is now read-only.

8269269: [macos11] SystemIconTest fails with ClassCastException #176

Closed
wants to merge 5 commits into from
Closed

8269269: [macos11] SystemIconTest fails with ClassCastException #176

wants to merge 5 commits into from

Conversation

@azuev-java
Copy link
Member

@azuev-java azuev-java commented Jun 29, 2021

8268280: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8269269: [macos11] SystemIconTest fails with ClassCastException
  • ⚠️ Failed to retrieve information on issue 8268280.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/176/head:pull/176
$ git checkout pull/176

Update a local copy of the PR:
$ git checkout pull/176
$ git pull https://git.openjdk.java.net/jdk17 pull/176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 176

View PR using the GUI difftool:
$ git pr show -t 176

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/176.diff

8268280: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

Added additional checks that will protect from false negative due to the
file being inaccessible or system environment variable overwritten
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 29, 2021

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@azuev-java The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the swing label Jun 29, 2021
@azuev-java
Copy link
Member Author

@azuev-java azuev-java commented Jun 29, 2021

/ussue add 8268280

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 29, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@azuev-java Unknown command ussue - for a list of valid commands use /help.

Loading

@@ -72,9 +72,20 @@ static void negativeTests() {

static void testSystemIcon(File file, boolean implComplete) {
int[] sizes = new int[] {16, 32, 48, 64, 128};
if (!file.exists() || !file.canRead()) {
Copy link
Member Author

@azuev-java azuev-java Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason for the Windows failure is that for some reason the default windir was not accessible - this check will avoid the situation where we are testing the icon for non-accessible folder - because in this case we will return the default UIManager icon for a file or a folder and this icon is not multi-resolution. On Mac it leads to the IconUIResource being returned and this Icon representation can not be casted to ImageIcon hence test fails.

Loading

@azuev-java
Copy link
Member Author

@azuev-java azuev-java commented Jun 29, 2021

/issue add 8268280

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@azuev-java The issue 8268280 was not found in the JDK project - make sure you have entered it correctly.
As there were validation problems, no additional issues will be added to the list of solved issues.

Loading

@azuev-java
Copy link
Member Author

@azuev-java azuev-java commented Jun 29, 2021

/issue add JDK-8268280

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@azuev-java The issue 8268280 was not found in the JDK project - make sure you have entered it correctly.
As there were validation problems, no additional issues will be added to the list of solved issues.

Loading

@azuev-java
Copy link
Member Author

@azuev-java azuev-java commented Jun 29, 2021

/issue add JDK-8268280

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@azuev-java
Adding additional issue to issue list: 8268280: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows.

Loading

@openjdk openjdk bot removed the rfr label Jun 29, 2021
…fails in Windows debug build

Reviewed-by: serb, psadhukhan, pbansal
openjdk-notifier[bot]
Copy link

openjdk-notifier bot commented on d042029 Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading

RealCLanger
Copy link
Contributor

RealCLanger commented on d042029 Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

Loading

openjdk[bot]
Copy link

openjdk bot commented on d042029 Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RealCLanger the backport was successfully created on the branch RealCLanger-backport-d0420295 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

this pull request contains a backport of commit d0420295 from the openjdk/jdk17 repository.

The commit being backported was authored by Christoph Langer on 29 Jun 2021 and was reviewed by Sergey Bylokhov, Prasanta Sadhukhan and Pankaj Bansal.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev RealCLanger-backport-d0420295:RealCLanger-backport-d0420295
$ git checkout RealCLanger-backport-d0420295
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev RealCLanger-backport-d0420295

Loading

azuev-java added 3 commits Jun 29, 2021
8268280: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

Added additional checks that will protect from false negative due to the
file being inaccessible or system environment variable overwritten
@azuev-java azuev-java closed this Jun 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

⚠️ @azuev-java This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

Loading

@openjdk openjdk bot added the rfr label Jun 29, 2021
@azuev-java azuev-java deleted the JDK-8269269 branch Jun 29, 2021
@victordyakov
Copy link
Contributor

@victordyakov victordyakov commented Jun 29, 2021

@prsadhuk @azvegint please review

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants