8269269: [macos11] SystemIconTest fails with ClassCastException

[azuev-java]

8268280: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issues

• JDK-8269269: [macos11] SystemIconTest fails with ClassCastException
• ⚠️ Failed to retrieve information on issue 8268280.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/176/head:pull/176
$ git checkout pull/176

Update a local copy of the PR:
$ git checkout pull/176
$ git pull https://git.openjdk.java.net/jdk17 pull/176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 176

View PR using the GUI difftool:
$ git pr show -t 176

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/176.diff

[bridgekeeper]

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azuev-java The following label will be automatically applied to this pull request:

• swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[azuev-java]

/ussue add 8268280

[mlbridge]

Webrevs

• 01: Full - Incremental (8619b7e2)
• 00: Full (5aeb8f8a)

[openjdk]

@azuev-java Unknown command ussue - for a list of valid commands use /help.

[azuev-java]

The main reason for the Windows failure is that for some reason the default windir was not accessible - this check will avoid the situation where we are testing the icon for non-accessible folder - because in this case we will return the default UIManager icon for a file or a folder and this icon is not multi-resolution. On Mac it leads to the IconUIResource being returned and this Icon representation can not be casted to ImageIcon hence test fails.

[azuev-java]

/issue add 8268280

[openjdk]

@azuev-java The issue 8268280 was not found in the JDK project - make sure you have entered it correctly.
As there were validation problems, no additional issues will be added to the list of solved issues.

[azuev-java]

/issue add JDK-8268280

[openjdk]

@azuev-java The issue 8268280 was not found in the JDK project - make sure you have entered it correctly.
As there were validation problems, no additional issues will be added to the list of solved issues.

[azuev-java]

/issue add JDK-8268280

[openjdk]

@azuev-java
Adding additional issue to issue list: 8268280: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows.

[openjdk]

⚠️ @azuev-java This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[victordyakov]

@prsadhuk @azvegint please review