8268897: [TESTBUG] compiler/compilercontrol/mixed/RandomCommandsTest.java must not fail on Command.quiet #184
Conversation
/reviewer credit @vnkozlov |
|
@neliasso |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial.
@neliasso This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks @vnkozlov /integrate |
Going to push as commit 0dc65d3.
Your commit was automatically rebased without conflicts. |
Hi,
This is a small fix of a test bug.
RandomCommandsTest.java can generate command file only containing a quiet command but with an invalid method descriptor. But Quiet commands are handled separately in the parser because they are just a global option. Any method descriptor will be discarded without validation.
This fix just makes sure we don't generate bad descriptor for quiet. That means we won't expect them to fail on the descriptor.
Please review,
Best regards,
Nils Eliasson
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/184/head:pull/184
$ git checkout pull/184
Update a local copy of the PR:
$ git checkout pull/184
$ git pull https://git.openjdk.java.net/jdk17 pull/184/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 184
View PR using the GUI difftool:
$ git pr show -t 184
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/184.diff