8268897: [TESTBUG] compiler/compilercontrol/mixed/RandomCommandsTest.java must not fail on Command.quiet

[neliasso]

Hi,

This is a small fix of a test bug.

RandomCommandsTest.java can generate command file only containing a quiet command but with an invalid method descriptor. But Quiet commands are handled separately in the parser because they are just a global option. Any method descriptor will be discarded without validation.

This fix just makes sure we don't generate bad descriptor for quiet. That means we won't expect them to fail on the descriptor.

Please review,
Best regards,
Nils Eliasson

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268897: [TESTBUG] compiler/compilercontrol/mixed/RandomCommandsTest.java must not fail on Command.quiet

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/184/head:pull/184
$ git checkout pull/184

Update a local copy of the PR:
$ git checkout pull/184
$ git pull https://git.openjdk.java.net/jdk17 pull/184/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 184

View PR using the GUI difftool:
$ git pr show -t 184

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/184.diff

[neliasso]

/reviewer credit @vnkozlov

[bridgekeeper]

👋 Welcome back neliasso! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@neliasso
Reviewer kvn successfully credited.

[openjdk]

@neliasso The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d6ed6d52)

[vnkozlov]

Trivial.

[openjdk]

@neliasso This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268897: [TESTBUG] compiler/compilercontrol/mixed/RandomCommandsTest.java must not fail on Command.quiet

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 3826012: 8268557: Module page uses unstyled table class
• 2b17e95: 8269691: ProblemList sun/management/jdp/JdpDefaultsTest.java on Linux-aarch64
• 1da5d4b: 8269486: CallerAccessTest fails for non server variant
• be0ac92: 8269614: [s390] Interpreter checks wrong bit for slow path instance allocation
• 4b4bef4: 8269594: assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark
• 4ee400a: 8268320: Better error recovery for broken patterns in switch
• ca283c3: 8265907: JVM crashes when matching VectorMaskCmp Node
• c3c9189: 8269141: Switch statement containing pattern case label element gets in the loop during execution
• 6b64a79: 8268350: Remove assert that ensures thread identifier remains the same
• 90eb118: 8269528: VectorAPI Long512VectorTest fails on X86 KNL target
• ... and 15 more: https://git.openjdk.java.net/jdk17/compare/d9cb068f4ba85e2be2ebc14e89e739b0a2d90409...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[neliasso]

Thanks @vnkozlov

/integrate

[openjdk]

Going to push as commit 0dc65d3.
Since your change was applied there have been 25 commits pushed to the master branch:

• 3826012: 8268557: Module page uses unstyled table class
• 2b17e95: 8269691: ProblemList sun/management/jdp/JdpDefaultsTest.java on Linux-aarch64
• 1da5d4b: 8269486: CallerAccessTest fails for non server variant
• be0ac92: 8269614: [s390] Interpreter checks wrong bit for slow path instance allocation
• 4b4bef4: 8269594: assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark
• 4ee400a: 8268320: Better error recovery for broken patterns in switch
• ca283c3: 8265907: JVM crashes when matching VectorMaskCmp Node
• c3c9189: 8269141: Switch statement containing pattern case label element gets in the loop during execution
• 6b64a79: 8268350: Remove assert that ensures thread identifier remains the same
• 90eb118: 8269528: VectorAPI Long512VectorTest fails on X86 KNL target
• ... and 15 more: https://git.openjdk.java.net/jdk17/compare/d9cb068f4ba85e2be2ebc14e89e739b0a2d90409...master

Your commit was automatically rebased without conflicts.

[openjdk]

@neliasso Pushed as commit 0dc65d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.