-
Notifications
You must be signed in to change notification settings - Fork 143
8269703: ProblemList vmTestbase/nsk/jvmti/scenarios/sampling/SP07/sp07t002/TestDescription.java on Windows-X64 with -Xcomp #186
Conversation
…7t002/TestDescription.java on Windows-X64 with -Xcomp
👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into |
/label add hotspot-runtime |
@dcubed-ojdk |
@dcubed-ojdk |
@dholmes-ora - Thanks for the fast review! |
@dcubed-ojdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@dcubed-ojdk Pushed as commit aba6c55. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Cool. I typo'ed the "/integrate" and then edited it. The command still worked. |
A trivial fix to ProblemList vmTestbase/nsk/jvmti/scenarios/sampling/SP07/sp07t002/TestDescription.java
on Windows-X64 with -Xcomp.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/186/head:pull/186
$ git checkout pull/186
Update a local copy of the PR:
$ git checkout pull/186
$ git pull https://git.openjdk.java.net/jdk17 pull/186/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 186
View PR using the GUI difftool:
$ git pr show -t 186
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/186.diff