Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8267448: Add "ulimit -a" to environment.html #2

Closed
wants to merge 2 commits into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Jun 10, 2021

(recreating openjdk/jdk#4451 against jdk17)

Hi all,

could you please review this small patch that does $subj?

Thanks,
-- Igor

attn: @plummercj

/cc hotspot-dev


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/2/head:pull/2
$ git checkout pull/2

Update a local copy of the PR:
$ git checkout pull/2
$ git pull https://git.openjdk.java.net/jdk17 pull/2/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2

View PR using the GUI difftool:
$ git pr show -t 2

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/2.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8267448 8267448: Add "ulimit -a" to environment.html Jun 10, 2021
@openjdk openjdk bot added rfr Pull request is ready for review hotspot hotspot-dev@openjdk.java.net labels Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@iignatev
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 10, 2021

Webrevs

Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Copyrights need updating.

@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267448: Add "ulimit -a" to environment.html

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5b8c51f: 8268539: several serviceability/sa tests should be run in driver mode

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 10, 2021
@iignatev
Copy link
Member Author

Thanks, Chris. I've updated the copyrights.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 10, 2021

Going to push as commit 53b6e2c.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 5b8c51f: 8268539: several serviceability/sa tests should be run in driver mode

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@iignatev Pushed as commit 53b6e2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot hotspot-dev@openjdk.java.net integrated Pull request has been integrated
2 participants