Skip to content
This repository has been archived by the owner. It is now read-only.

8269830: SA's vm object vtable matching code sometimes matches on incorrect type #206

Closed
wants to merge 1 commit into from

Conversation

@plummercj
Copy link
Contributor

@plummercj plummercj commented Jul 2, 2021

See the CR for details. This issue is causing a lot of failures related to some threads occasionally not being included in the jstack output, such as SteadyStateThread, Common-Cleaner, and "Signal Dispatcher". The bug caused SA to sometimes think a JavaThread object is actually an instance of the CompilerThread subclass, even though it is not. This results in jstack not including the thread in the output since it purposefully omits CompilerThreads.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269830: SA's vm object vtable matching code sometimes matches on incorrect type

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/206/head:pull/206
$ git checkout pull/206

Update a local copy of the PR:
$ git checkout pull/206
$ git pull https://git.openjdk.java.net/jdk17 pull/206/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 206

View PR using the GUI difftool:
$ git pr show -t 206

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/206.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 2, 2021

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 2, 2021

Webrevs

Copy link

@kevinjwalls kevinjwalls left a comment

Much simpler!

@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Jul 6, 2021

Much simpler!

Thank you Kevin!

Can I get one more review please?

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Nice cleanup.
Thanks,
Serguei

@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269830: SA's vm object vtable matching code sometimes matches on incorrect type

Reviewed-by: kevinw, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 163 new commits pushed to the master branch:

  • 1166ef2: 8268966: AArch64: 'bad AD file' in some vector conversion tests
  • 3a69024: 8225667: Clarify the behavior of System::gc w.r.t. reference processing
  • 2b20778: 8269568: JVM crashes when running VectorMask query tests
  • 0f4e07b: 8269661: JNI_GetStringCritical does not lock char array
  • df1364b: 8269575: C2: assert(false) failed: graph should be schedulable after JDK-8252372
  • 6d8fc72: 8268883: C2: assert(false) failed: unscheduable graph
  • 4ad8b04: 8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null check
  • 5b8e1a2: 8266595: jdk/jfr/jcmd/TestJcmdDump.java with slowdebug bits fails with AttachNotSupportedException
  • e14801c: 8269668: [aarch64] java.library.path not including /usr/lib64
  • 97e0e9e: 8268775: Password is being converted to String in AccessibleJPasswordField
  • ... and 153 more: https://git.openjdk.java.net/jdk17/compare/c088d093e2e73fd0739d9e96f9f5ea67a01ae06c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 6, 2021
@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Jul 6, 2021

Thanks Serguei!

@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Jul 7, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

Going to push as commit 2daf39a.
Since your change was applied there have been 166 commits pushed to the master branch:

  • 0ebf8aa: 8268778: CDS check_excluded_classes needs DumpTimeTable_lock
  • 0d1cd3a: 8269825: [TESTBUG] Missing testing for x86 KNL platforms
  • e0c130f: 8269955: ProblemList compiler/vectorapi/VectorCastShape[64|128]Test.java tests on x86
  • 1166ef2: 8268966: AArch64: 'bad AD file' in some vector conversion tests
  • 3a69024: 8225667: Clarify the behavior of System::gc w.r.t. reference processing
  • 2b20778: 8269568: JVM crashes when running VectorMask query tests
  • 0f4e07b: 8269661: JNI_GetStringCritical does not lock char array
  • df1364b: 8269575: C2: assert(false) failed: graph should be schedulable after JDK-8252372
  • 6d8fc72: 8268883: C2: assert(false) failed: unscheduable graph
  • 4ad8b04: 8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null check
  • ... and 156 more: https://git.openjdk.java.net/jdk17/compare/c088d093e2e73fd0739d9e96f9f5ea67a01ae06c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@plummercj Pushed as commit 2daf39a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants