Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.

Conversation

@dfuch
Copy link
Member

@dfuch dfuch commented Jul 5, 2021

Please find here a trivial fix for:

8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"

Running several of the websocket tests concurrently on some of the CI machines is causing resource exhaustion, because resources are only freed after the TIMED_WAIT delay has expired once the tests have finished.
The proposed solution is to run these tests in exclusive dir mode.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/210/head:pull/210
$ git checkout pull/210

Update a local copy of the PR:
$ git checkout pull/210
$ git pull https://git.openjdk.java.net/jdk17 pull/210/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 210

View PR using the GUI difftool:
$ git pr show -t 210

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/210.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2021

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 5, 2021
@openjdk
Copy link

openjdk bot commented Jul 5, 2021

@dfuch The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.java.net label Jul 5, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 5, 2021

Webrevs

@dfuch
Copy link
Member Author

dfuch commented Jul 5, 2021

/label net

@openjdk openjdk bot added the net net-dev@openjdk.java.net label Jul 5, 2021
@openjdk
Copy link

openjdk bot commented Jul 5, 2021

@dfuch
The net label was successfully added.

@openjdk
Copy link

openjdk bot commented Jul 6, 2021

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"

Reviewed-by: chegar, vtewari

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 2daf39a: 8269830: SA's vm object vtable matching code sometimes matches on incorrect type
  • 0ebf8aa: 8268778: CDS check_excluded_classes needs DumpTimeTable_lock
  • 0d1cd3a: 8269825: [TESTBUG] Missing testing for x86 KNL platforms
  • e0c130f: 8269955: ProblemList compiler/vectorapi/VectorCastShape[64|128]Test.java tests on x86
  • 1166ef2: 8268966: AArch64: 'bad AD file' in some vector conversion tests
  • 3a69024: 8225667: Clarify the behavior of System::gc w.r.t. reference processing
  • 2b20778: 8269568: JVM crashes when running VectorMask query tests
  • 0f4e07b: 8269661: JNI_GetStringCritical does not lock char array
  • df1364b: 8269575: C2: assert(false) failed: graph should be schedulable after JDK-8252372
  • 6d8fc72: 8268883: C2: assert(false) failed: unscheduable graph
  • ... and 2 more: https://git.openjdk.java.net/jdk17/compare/e14801cdd9b108aa4ca47d0bc1dc67fca575764c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 6, 2021
@dfuch
Copy link
Member Author

dfuch commented Jul 7, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 7, 2021

Going to push as commit a49b1dc.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 820f290: 8268859: jshell throws exception while parsing illegal "case true"
  • 815e4af: 8269802: javac fails to compile nested pattern matching switches
  • 2daf39a: 8269830: SA's vm object vtable matching code sometimes matches on incorrect type
  • 0ebf8aa: 8268778: CDS check_excluded_classes needs DumpTimeTable_lock
  • 0d1cd3a: 8269825: [TESTBUG] Missing testing for x86 KNL platforms
  • e0c130f: 8269955: ProblemList compiler/vectorapi/VectorCastShape[64|128]Test.java tests on x86
  • 1166ef2: 8268966: AArch64: 'bad AD file' in some vector conversion tests
  • 3a69024: 8225667: Clarify the behavior of System::gc w.r.t. reference processing
  • 2b20778: 8269568: JVM crashes when running VectorMask query tests
  • 0f4e07b: 8269661: JNI_GetStringCritical does not lock char array
  • ... and 4 more: https://git.openjdk.java.net/jdk17/compare/e14801cdd9b108aa4ca47d0bc1dc67fca575764c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 7, 2021
@openjdk
Copy link

openjdk bot commented Jul 7, 2021

@dfuch Pushed as commit a49b1dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core-libs core-libs-dev@openjdk.java.net integrated Pull request has been integrated net net-dev@openjdk.java.net

Development

Successfully merging this pull request may close these issues.

3 participants