Skip to content
This repository has been archived by the owner. It is now read-only.

8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field #213

Closed

Conversation

mychris
Copy link
Member

@mychris mychris commented Jul 5, 2021

Hi,

please review this small change for two Clhsdb test cases, which are using C2 specific fields during testing. This makes the tests fail, if C2 is not available during testing.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/213/head:pull/213
$ git checkout pull/213

Update a local copy of the PR:
$ git checkout pull/213
$ git pull https://git.openjdk.java.net/jdk17 pull/213/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 213

View PR using the GUI difftool:
$ git pr show -t 213

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/213.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 5, 2021

👋 Welcome back cgo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 5, 2021

@mychris The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability label Jul 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 5, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

@mychris This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field

Reviewed-by: cjplummer, dholmes, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 0ebf8aa: 8268778: CDS check_excluded_classes needs DumpTimeTable_lock
  • 0d1cd3a: 8269825: [TESTBUG] Missing testing for x86 KNL platforms
  • e0c130f: 8269955: ProblemList compiler/vectorapi/VectorCastShape[64|128]Test.java tests on x86
  • 1166ef2: 8268966: AArch64: 'bad AD file' in some vector conversion tests
  • 3a69024: 8225667: Clarify the behavior of System::gc w.r.t. reference processing
  • 2b20778: 8269568: JVM crashes when running VectorMask query tests
  • 0f4e07b: 8269661: JNI_GetStringCritical does not lock char array
  • df1364b: 8269575: C2: assert(false) failed: graph should be schedulable after JDK-8252372
  • 6d8fc72: 8268883: C2: assert(false) failed: unscheduable graph
  • 4ad8b04: 8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null check
  • ... and 1 more: https://git.openjdk.java.net/jdk17/compare/e14801cdd9b108aa4ca47d0bc1dc67fca575764c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@plummercj, @dholmes-ora, @sspitsyn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jul 6, 2021
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good.

@mychris
Copy link
Member Author

@mychris mychris commented Jul 6, 2021

Thanks for the reviews.
/integrate

@openjdk openjdk bot added the sponsor label Jul 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 6, 2021

@mychris
Your change (at version f783cb0) is now ready to be sponsored by a Committer.

@mychris
Copy link
Member Author

@mychris mychris commented Jul 12, 2021

Could someone please sponsor this change for me?

@kevinjwalls
Copy link

@kevinjwalls kevinjwalls commented Jul 12, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

Going to push as commit 999ced0.
Since your change was applied there have been 36 commits pushed to the master branch:

  • e1d3e73: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • 3d82b0e: 8269558: fix of JDK-8252657 missed to update history at the end of JVM TI spec
  • 2546006: 8270216: [macOS] Update named used for Java run loop mode
  • 6889a39: 8268826: Cleanup Override in Context-Specific Deserialization Filters
  • f791fdf: 8261147: C2: Node is wrongly marked as reduction resulting in a wrong execution due to wrong vector instructions
  • 1196b35: 8270151: IncompatibleClassChangeError on empty pattern switch statement case
  • 885f7b1: 8269146: Missing unreported constraints on pattern and other case label combination
  • 62ff55d: 8269952: compiler/vectorapi/VectorCastShape*Test.java tests failed on avx2 machines
  • 46c610c: 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms
  • 6401633: 8269722: NPE in HtmlDocletWriter
  • ... and 26 more: https://git.openjdk.java.net/jdk17/compare/e14801cdd9b108aa4ca47d0bc1dc67fca575764c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@kevinjwalls @mychris Pushed as commit 999ced0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated serviceability
5 participants