8269575: C2: assert(false) failed: graph should be schedulable after JDK-8252372

[rwestrel]

8252372 moved processing of Phis by anti-dependence analysis in the:

for (uint i = 0; i < worklist.size() && LCA != early; i++) {

loop by accident. The intent is to process all Phis last.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269575: C2: assert(false) failed: graph should be schedulable after JDK-8252372

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to d942c14
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/214/head:pull/214
$ git checkout pull/214

Update a local copy of the PR:
$ git checkout pull/214
$ git pull https://git.openjdk.java.net/jdk17 pull/214/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 214

View PR using the GUI difftool:
$ git pr show -t 214

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/214.diff

[bridgekeeper]

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rwestrel The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (50e09ec4)
• 00: Full (d942c143)

[vnkozlov]

Looks good.

[openjdk]

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269575: C2: assert(false) failed: graph should be schedulable after JDK-8252372

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 6d8fc72: 8268883: C2: assert(false) failed: unscheduable graph
• 4ad8b04: 8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null check
• 5b8e1a2: 8266595: jdk/jfr/jcmd/TestJcmdDump.java with slowdebug bits fails with AttachNotSupportedException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good to me too - although the test could use some cleanup :)

[rwestrel]

@vnkozlov @TobiHartmann thanks for the reviews

[rwestrel]

/integrate

[openjdk]

Going to push as commit df1364b.
Since your change was applied there have been 3 commits pushed to the master branch:

• 6d8fc72: 8268883: C2: assert(false) failed: unscheduable graph
• 4ad8b04: 8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null check
• 5b8e1a2: 8266595: jdk/jfr/jcmd/TestJcmdDump.java with slowdebug bits fails with AttachNotSupportedException

Your commit was automatically rebased without conflicts.

[openjdk]

@rwestrel Pushed as commit df1364b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.