Skip to content
This repository has been archived by the owner. It is now read-only.

8269952: compiler/vectorapi/VectorCastShape*Test.java tests failed on avx2 machines #226

Closed
wants to merge 3 commits into from

Conversation

jatin-bhateja
Copy link
Member

@jatin-bhateja jatin-bhateja commented Jul 7, 2021

  • Problem relates to incorrect operands being passed and handling for KNL platform which does not support AVX512VLBW feature.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269952: compiler/vectorapi/VectorCastShape*Test.java tests failed on avx2 machines

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/226/head:pull/226
$ git checkout pull/226

Update a local copy of the PR:
$ git checkout pull/226
$ git pull https://git.openjdk.java.net/jdk17 pull/226/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 226

View PR using the GUI difftool:
$ git pr show -t 226

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/226.diff

@jatin-bhateja
Copy link
Member Author

@jatin-bhateja jatin-bhateja commented Jul 7, 2021

/label hotspot-compiler-dev

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 7, 2021

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-compiler label Jul 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@jatin-bhateja
The hotspot-compiler label was successfully added.

@@ -42,6 +42,7 @@
* @summary AArch64: 'bad AD file' in some vector conversion tests
* @modules jdk.incubator.vector
* @run testng/othervm -XX:-TieredCompilation compiler.vectorapi.VectorCastShape128Test
* @run testng/othervm -XX:-TieredCompilation -XX:+UnlockDiagnosticVMOptions -XX:+UseKNLSetting compiler.vectorapi.VectorCastShape128Test
Copy link
Contributor

@theRealELiu theRealELiu Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose UseKNLSetting is a x86 specific option, is this okay for other platforms?

Copy link
Contributor

@theRealELiu theRealELiu left a comment

These 2 test cases should be removed from test/hotspot/jtreg/ProblemList.txt[1] in your patch. See #221 for more details.

[1] https://github.com/vnkozlov/jdk17/blob/18a3c59a9bc54c6999e9c72b77c3fc73752df7a5/test/hotspot/jtreg/ProblemList.txt#L73

@openjdk openjdk bot added the rfr label Jul 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 8, 2021

Webrevs

@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Jul 8, 2021

Yes, you don't need to add new run commands in tests. We are running these tests with these flags on avx512 machines in our testing.

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Looks good. I will run tests.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@jatin-bhateja This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269952: compiler/vectorapi/VectorCastShape*Test.java tests failed on avx2 machines

Reviewed-by: kvn, dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 9e75f92: 8269738: AssertionError when combining pattern matching and function closure
  • 168af2e: 8269828: corrections in some instruction patterns for KNL x86 platform
  • fa08cc6: 8268766: Desugaring of pattern matching enum switch should be improved
  • 4f70759: 8270006: Switches with 'case null:' should be exhaustive
  • 8f798b8: 8269746: C2: assert(!in->is_CFG()) failed: CFG Node with no controlling input?
  • c812bbb: 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for unexpected output
  • 6000950: 8269185: Directories in /opt/runtimepackagetest and /path/to/jdk-17 are different
  • 1f2bf1d: 8269879: [PPC64] C2: Math.rint intrinsic uses wrong rounding mode
  • 7fcd5ca: 8266036: class file for sun.misc.Contended not found
  • a49b1dc: 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"
  • ... and 2 more: https://git.openjdk.java.net/jdk17/compare/2daf39a59b2d51f25b03bb78edd677a1bab4433c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 8, 2021
@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Jul 8, 2021

tier1-3 testing passed (it included runs with -XX:+UseKNLSetting).

@jatin-bhateja
Copy link
Member Author

@jatin-bhateja jatin-bhateja commented Jul 9, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

Going to push as commit 62ff55d.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 46c610c: 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms
  • 6401633: 8269722: NPE in HtmlDocletWriter
  • 9acb2a6: 8270109: ProblemList 4 SA tests on macOS-aarch64
  • f46a917: 6766844: ByteArrayInputStream#read with a byte array of length 0 not consistent with InputStream when at EOF
  • 9e75f92: 8269738: AssertionError when combining pattern matching and function closure
  • 168af2e: 8269828: corrections in some instruction patterns for KNL x86 platform
  • fa08cc6: 8268766: Desugaring of pattern matching enum switch should be improved
  • 4f70759: 8270006: Switches with 'case null:' should be exhaustive
  • 8f798b8: 8269746: C2: assert(!in->is_CFG()) failed: CFG Node with no controlling input?
  • c812bbb: 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for unexpected output
  • ... and 6 more: https://git.openjdk.java.net/jdk17/compare/2daf39a59b2d51f25b03bb78edd677a1bab4433c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@jatin-bhateja Pushed as commit 62ff55d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-compiler integrated
4 participants