Skip to content
This repository has been archived by the owner. It is now read-only.

8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms #229

Conversation

@mseledts
Copy link
Member

@mseledts mseledts commented Jul 8, 2021

Now that "JDK-8268212 Build linux-aarch64 natively" added support for default CDS archive, time to update test configuration for this platform. This is a very small one-line change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/229/head:pull/229
$ git checkout pull/229

Update a local copy of the PR:
$ git checkout pull/229
$ git pull https://git.openjdk.java.net/jdk17 pull/229/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 229

View PR using the GUI difftool:
$ git pr show -t 229

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/229.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 8, 2021

👋 Welcome back mseledtsov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 8, 2021
@mseledts
Copy link
Member Author

@mseledts mseledts commented Jul 8, 2021

Testing:
Grepped test sources for isDefaultCDSArchiveSupported. Found the following tests references:
test/hotspot/jtreg/runtime/cds/CheckDefaultArchiveFile.java,test/hotspot/jtreg/runtime/cds/CheckSharingWithDefaultArchive.java,test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java

Running these tests on Linux-aarch64.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@mseledts The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mseledts
Copy link
Member Author

@mseledts mseledts commented Jul 8, 2021

@ioilam @calvinccheung @lmesnik Could you please review this one-liner when you have a chance?

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 8, 2021

Webrevs

Loading

yminqi
yminqi approved these changes Jul 8, 2021
Copy link
Contributor

@yminqi yminqi left a comment

LGTM.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@mseledts This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms

Reviewed-by: minqi, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 9acb2a6: 8270109: ProblemList 4 SA tests on macOS-aarch64
  • f46a917: 6766844: ByteArrayInputStream#read with a byte array of length 0 not consistent with InputStream when at EOF
  • 9e75f92: 8269738: AssertionError when combining pattern matching and function closure
  • 168af2e: 8269828: corrections in some instruction patterns for KNL x86 platform
  • fa08cc6: 8268766: Desugaring of pattern matching enum switch should be improved
  • 4f70759: 8270006: Switches with 'case null:' should be exhaustive
  • 8f798b8: 8269746: C2: assert(!in->is_CFG()) failed: CFG Node with no controlling input?
  • c812bbb: 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for unexpected output

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 8, 2021
iklam
iklam approved these changes Jul 8, 2021
Copy link
Member

@iklam iklam left a comment

Looks good, but this returns true also for osx-aarch64 and windows-aarch64, so the comment message needs to be updated.

Loading

@mseledts mseledts changed the title 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for Linux-aarch64 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms Jul 8, 2021
@mseledts
Copy link
Member Author

@mseledts mseledts commented Jul 8, 2021

Thanks Ioi. I have updated the issue description and PR description to "Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms". I can test on Linux-aarch64 and MacOsx-aarch64. I presume Windows-aarch64 is built natively by the OpenJDK community members (if it is built and tested), then this should be fine.

Loading

@mseledts
Copy link
Member Author

@mseledts mseledts commented Jul 9, 2021

Yumin, Ioi, thanks for the review.

All relevant tests passed.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

Going to push as commit 46c610c.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 6401633: 8269722: NPE in HtmlDocletWriter
  • 9acb2a6: 8270109: ProblemList 4 SA tests on macOS-aarch64
  • f46a917: 6766844: ByteArrayInputStream#read with a byte array of length 0 not consistent with InputStream when at EOF
  • 9e75f92: 8269738: AssertionError when combining pattern matching and function closure
  • 168af2e: 8269828: corrections in some instruction patterns for KNL x86 platform
  • fa08cc6: 8268766: Desugaring of pattern matching enum switch should be improved
  • 4f70759: 8270006: Switches with 'case null:' should be exhaustive
  • 8f798b8: 8269746: C2: assert(!in->is_CFG()) failed: CFG Node with no controlling input?
  • c812bbb: 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for unexpected output

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@mseledts Pushed as commit 46c610c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants