Skip to content
This repository has been archived by the owner. It is now read-only.

8266345: (fs) Custom DefaultFileSystemProvider security related loops #232

Closed
wants to merge 1 commit into from

Conversation

seanjmullan
Copy link
Member

@seanjmullan seanjmullan commented Jul 8, 2021

Please review this fix to use the platform's default file system to avoid recursive policy initialization
issues when a SecurityManager is enabled and the VM is configured to use a custom file system provider.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266345: (fs) Custom DefaultFileSystemProvider security related loops

Reviewers

Contributors

  • Brian Burkhalter <bpb@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/232/head:pull/232
$ git checkout pull/232

Update a local copy of the PR:
$ git checkout pull/232
$ git pull https://git.openjdk.java.net/jdk17 pull/232/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 232

View PR using the GUI difftool:
$ git pr show -t 232

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/232.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 8, 2021

👋 Welcome back mullan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@seanjmullan The following labels will be automatically applied to this pull request:

  • nio
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security nio labels Jul 8, 2021
@seanjmullan
Copy link
Member Author

@seanjmullan seanjmullan commented Jul 8, 2021

/contributor bplb

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@seanjmullan Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 8, 2021

Webrevs

@seanjmullan
Copy link
Member Author

@seanjmullan seanjmullan commented Jul 8, 2021

/contributor bpb

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@seanjmullan Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@seanjmullan
Copy link
Member Author

@seanjmullan seanjmullan commented Jul 8, 2021

/contributor add bpb

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@seanjmullan
Contributor Brian Burkhalter <bpb@openjdk.org> successfully added.

bplb
bplb approved these changes Jul 8, 2021
Copy link
Member

@bplb bplb left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@seanjmullan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266345: (fs) Custom DefaultFileSystemProvider security related loops

Co-authored-by: Brian Burkhalter <bpb@openjdk.org>
Reviewed-by: bpb, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 999ced0: 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field
  • e1d3e73: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • 3d82b0e: 8269558: fix of JDK-8252657 missed to update history at the end of JVM TI spec
  • 2546006: 8270216: [macOS] Update named used for Java run loop mode
  • 6889a39: 8268826: Cleanup Override in Context-Specific Deserialization Filters
  • f791fdf: 8261147: C2: Node is wrongly marked as reduction resulting in a wrong execution due to wrong vector instructions
  • 1196b35: 8270151: IncompatibleClassChangeError on empty pattern switch statement case
  • 885f7b1: 8269146: Missing unreported constraints on pattern and other case label combination
  • 62ff55d: 8269952: compiler/vectorapi/VectorCastShape*Test.java tests failed on avx2 machines
  • 46c610c: 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms
  • ... and 6 more: https://git.openjdk.java.net/jdk17/compare/4f707591754e5e7f747d1d0a47f78f49060771c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 8, 2021
@seanjmullan
Copy link
Member Author

@seanjmullan seanjmullan commented Jul 12, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

Going to push as commit 4fc3180.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 999ced0: 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field
  • e1d3e73: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • 3d82b0e: 8269558: fix of JDK-8252657 missed to update history at the end of JVM TI spec
  • 2546006: 8270216: [macOS] Update named used for Java run loop mode
  • 6889a39: 8268826: Cleanup Override in Context-Specific Deserialization Filters
  • f791fdf: 8261147: C2: Node is wrongly marked as reduction resulting in a wrong execution due to wrong vector instructions
  • 1196b35: 8270151: IncompatibleClassChangeError on empty pattern switch statement case
  • 885f7b1: 8269146: Missing unreported constraints on pattern and other case label combination
  • 62ff55d: 8269952: compiler/vectorapi/VectorCastShape*Test.java tests failed on avx2 machines
  • 46c610c: 8269840: Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms
  • ... and 6 more: https://git.openjdk.java.net/jdk17/compare/4f707591754e5e7f747d1d0a47f78f49060771c2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@seanjmullan Pushed as commit 4fc3180.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Jul 19, 2021

Adding @bug 8266345 to the test will make it look like the test was created for this JBS issue. It was originally added for JDK-4313887, updated via JDK-7006126, but I think the bug tag was dropped when it was refactored for modules. So I think we will need to fix the bug tag in a follow-up issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated nio security
4 participants