-
Notifications
You must be signed in to change notification settings - Fork 146
8269558: fix of JDK-8252657 missed to update history at the end of JVM TI spec #233
Conversation
👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up. This looks like a trivial fix to me.
@sspitsyn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Dan and Chris, thank you for quick review! |
/integrate |
/integrate |
Going to push as commit 3d82b0e. |
@sspitsyn The command |
The fix of:
8252657 JVMTI agent is not unloaded when Agent_OnAttach is failed
did not update the JVM TI spec history at the end of document.
This PR adds missed item to the JVM TI spec history.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/233/head:pull/233
$ git checkout pull/233
Update a local copy of the PR:
$ git checkout pull/233
$ git pull https://git.openjdk.java.net/jdk17 pull/233/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 233
View PR using the GUI difftool:
$ git pr show -t 233
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/233.diff