-
Notifications
You must be signed in to change notification settings - Fork 147
8270203: Missing build dependency between jdk.jfr-gendata and buildtools-hotspot #239
Conversation
👋 Welcome back erikj! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@erikj79 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
make/Main.gmk
Outdated
@@ -857,6 +857,9 @@ else | |||
# virtual target. | |||
jdk.jdwp.agent-libs: jdk.jdwp.agent-gensrc | |||
|
|||
# jdk.jfr-gensrc uses TOOL_JFR_GEN from buildtools-hotspot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment and the code do not match. I assume the comment is incorrect.
/integrate |
Going to push as commit 0f32982.
Your commit was automatically rebased without conflicts. |
Add missing make dependency in Main.gmk.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/239/head:pull/239
$ git checkout pull/239
Update a local copy of the PR:
$ git checkout pull/239
$ git pull https://git.openjdk.java.net/jdk17 pull/239/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 239
View PR using the GUI difftool:
$ git pr show -t 239
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/239.diff