Skip to content
This repository has been archived by the owner. It is now read-only.

JDK-8270075 SplittableRandom extends AbstractSplittableGenerator #243

Closed
wants to merge 2 commits into from

Conversation

@JimLaskey
Copy link
Member

@JimLaskey JimLaskey commented Jul 12, 2021

Random.AbstractSplittableGenerator is an internal class that should not be exposed in a public API.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270075: SplittableRandom extends AbstractSplittableGenerator

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/243/head:pull/243
$ git checkout pull/243

Update a local copy of the PR:
$ git checkout pull/243
$ git pull https://git.openjdk.java.net/jdk17 pull/243/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 243

View PR using the GUI difftool:
$ git pr show -t 243

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/243.diff

@JimLaskey
Copy link
Member Author

@JimLaskey JimLaskey commented Jul 12, 2021

/csr

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 12, 2021

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@JimLaskey has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@JimLaskey please create a CSR request for issue JDK-8270075. This pull request cannot be integrated until the CSR request is approved.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@JimLaskey The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Jul 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 12, 2021

Webrevs

Loading

bplb
bplb approved these changes Jul 12, 2021
@openjdk openjdk bot removed the csr label Jul 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 12, 2021

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270075: SplittableRandom extends AbstractSplittableGenerator

Reviewed-by: rriggs, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 12, 2021
@JimLaskey
Copy link
Member Author

@JimLaskey JimLaskey commented Jul 14, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 14, 2021

Going to push as commit 3bbd233.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 381bd62: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run
  • 82c256e: 8259499: Handling type arguments from outer classes for inner class in javadoc
  • e5db9a9: 8268620: InfiniteLoopException test may fail on x86 platforms
  • 67273ae: 8269865: Async UL needs to handle ERANGE on exceeding SEM_VALUE_MAX
  • 0f54707: 8270056: Generated lambda class can not access protected static method of target class
  • 8583aab: 8270025: DynamicCallSiteDesc::withArgs doesn't throw NPE
  • d32e42c: 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 14, 2021

@JimLaskey Pushed as commit 3bbd233.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants