Skip to content
This repository has been archived by the owner. It is now read-only.

8270056: Generated lambda class can not access protected static method of target class #245

Closed

Conversation

@kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Jul 13, 2021

Hi all,

this pull request contains a backport of commit 07e90524 from the openjdk/jdk repository.

The commit being backported was authored by Yi Yang on 13 Jul 2021 and was reviewed by Mandy Chung.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270056: Generated lambda class can not access protected static method of target class

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/245/head:pull/245
$ git checkout pull/245

Update a local copy of the PR:
$ git checkout pull/245
$ git pull https://git.openjdk.java.net/jdk17 pull/245/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 245

View PR using the GUI difftool:
$ git pr show -t 245

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/245.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 13, 2021

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 07e90524576f159fc16523430f1db62327c89a3b 8270056: Generated lambda class can not access protected static method of target class Jul 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270056: Generated lambda class can not access protected static method of target class

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • d32e42c: 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas
  • b2416b6: 8269281: java/foreign/Test{Down,Up}call.java time out
  • bd95c0c: 8269635: Stress test SEGV while emitting OldObjectSample
  • 00ef65f: 8269525: Deadlock during Volano with JFR
  • e631add: 8259848: Interim javadoc build does not support platform links
  • 040c02b: 8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV
  • 0f32982: 8270203: Missing build dependency between jdk.jfr-gendata and buildtools-hotspot

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@kelthuzadx The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Jul 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 13, 2021

Webrevs

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Jul 14, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 14, 2021

Going to push as commit 0f54707.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 8583aab: 8270025: DynamicCallSiteDesc::withArgs doesn't throw NPE
  • d32e42c: 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas
  • b2416b6: 8269281: java/foreign/Test{Down,Up}call.java time out
  • bd95c0c: 8269635: Stress test SEGV while emitting OldObjectSample
  • 00ef65f: 8269525: Deadlock during Volano with JFR
  • e631add: 8259848: Interim javadoc build does not support platform links
  • 040c02b: 8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV
  • 0f32982: 8270203: Missing build dependency between jdk.jfr-gendata and buildtools-hotspot

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 14, 2021

@kelthuzadx Pushed as commit 0f54707.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants