Skip to content
This repository has been archived by the owner. It is now read-only.

8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas #246

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jul 13, 2021

Clean backport. Test-only change. Test passes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/246/head:pull/246
$ git checkout pull/246

Update a local copy of the PR:
$ git checkout pull/246
$ git pull https://git.openjdk.java.net/jdk17 pull/246/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 246

View PR using the GUI difftool:
$ git pr show -t 246

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/246.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 13, 2021

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6a9bc108736522897f03a75c83e90e2c2a183d27 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas Jul 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 040c02b: 8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jul 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@jerboaa The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Jul 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 13, 2021

Webrevs

@jerboaa
Copy link
Contributor Author

@jerboaa jerboaa commented Jul 13, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

Going to push as commit d32e42c.
Since your change was applied there have been 5 commits pushed to the master branch:

  • b2416b6: 8269281: java/foreign/Test{Down,Up}call.java time out
  • bd95c0c: 8269635: Stress test SEGV while emitting OldObjectSample
  • 00ef65f: 8269525: Deadlock during Volano with JFR
  • e631add: 8259848: Interim javadoc build does not support platform links
  • 040c02b: 8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@jerboaa Pushed as commit d32e42c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot-compiler integrated
1 participant