-
Notifications
You must be signed in to change notification settings - Fork 155
8270422: Test build/AbsPathsInImage.java fails after JDK-8259848 #249
Conversation
|
👋 Welcome back erikj! A progress list of the required criteria for merging this PR into |
|
@erikj79 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 7b4d84c.
Your commit was automatically rebased without conflicts. |
This patch extends the filter for marker files when creating jmods. Our latest established marker file format is
_*.markerand through ExecuteWithLog, we regularly append additional suffixes to such file names. Thus I propose we simply extend the filter pattern to_*.marker*.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/249/head:pull/249$ git checkout pull/249Update a local copy of the PR:
$ git checkout pull/249$ git pull https://git.openjdk.java.net/jdk17 pull/249/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 249View PR using the GUI difftool:
$ git pr show -t 249Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/249.diff