8268602: a couple runtime/os tests don't check exit code

[iignatev]

Hi all,

could you please review this trivial and test-only patch that adds checks of exit code to two runtime/os tests?
from JBS:

runtime/os/TestUseCpuAllocPath.java and AvailableProcessors.java spawn new JVMs but don't check their exit code which might lead to both type-I and type-II errors

testing: ``runtime/oson{linux,windows,macosx}-x64`

Thanks,
-- Igor

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268602: a couple runtime/os tests don't check exit code

Reviewers

• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to abaabc2

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/25/head:pull/25
$ git checkout pull/25

Update a local copy of the PR:
$ git checkout pull/25
$ git pull https://git.openjdk.java.net/jdk17 pull/25/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25

View PR using the GUI difftool:
$ git pr show -t 25

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/25.diff

[bridgekeeper]

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iignatev The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1c3cae32)
• 00: Full (abaabc29)

[dholmes-ora]

The value of doing this seems marginal, but strictly speaking yes every test that launches VM should check for a zero exit code. Arguably this should be built into the ProcessTools API so that we don't have to do it explicitly. The special case would be looking for a non-zero exit code.

In the case of failure it is more efficient to check the exit code first before potentially wasting time parsing output. But we probably don't care too much about that.

Thanks,
David

[openjdk]

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268602: a couple runtime/os tests don't check exit code

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iignatev]

thanks, David. I've moved OutputAnalyzer::shouldHaveExitValue calls. I agree that it makes sense to update ProcessTools API to always check exit code; I'll file an RFE for that.

/integrate

[openjdk]

Going to push as commit cce8da2.

[openjdk]

@iignatev Pushed as commit cce8da2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.