Skip to content
This repository has been archived by the owner. It is now read-only.

8270993: Missing forward declaration of ZeroFrame #259

Closed
wants to merge 1 commit into from

Conversation

@JesperIRL
Copy link
Member

@JesperIRL JesperIRL commented Jul 20, 2021

Fix build failure on Zero.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270993: Missing forward declaration of ZeroFrame

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/259/head:pull/259
$ git checkout pull/259

Update a local copy of the PR:
$ git checkout pull/259
$ git pull https://git.openjdk.java.net/jdk17 pull/259/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 259

View PR using the GUI difftool:
$ git pr show -t 259

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/259.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 20, 2021

👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

@JesperIRL The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@JesperIRL JesperIRL changed the title Added class ZeroFrame 8270993: Added class ZeroFrame Jul 21, 2021
@openjdk openjdk bot added the rfr label Jul 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 21, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@JesperIRL JesperIRL changed the title 8270993: Added class ZeroFrame 8270993: Missing forward declaration of ZeroFrame Jul 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@JesperIRL This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270993: Missing forward declaration of ZeroFrame

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 21, 2021
@JesperIRL
Copy link
Member Author

@JesperIRL JesperIRL commented Jul 21, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

Going to push as commit 61359c4.

@openjdk openjdk bot closed this Jul 21, 2021
@openjdk openjdk bot added integrated and removed ready labels Jul 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@JesperIRL Pushed as commit 61359c4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants