8268333: javac crashes when pattern matching switch contains default case which is not last

[lahodaj]

[this is a copy of a PR from openjdk/jdk:
https://github.com/openjdk/jdk/pull/4397
]

The pattern matching switch desugaring should recognize cases where there is default case followed by a type pattern case, and not replace the type pattern with another default.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268333: javac crashes when pattern matching switch contains default case which is not last

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/26/head:pull/26
$ git checkout pull/26

Update a local copy of the PR:
$ git checkout pull/26
$ git pull https://git.openjdk.java.net/jdk17 pull/26/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26

View PR using the GUI difftool:
$ git pr show -t 26

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/26.diff

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (02be7240)

[vicente-romero-oracle]

looks good!

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268333: javac crashes when pattern matching switch contains default case which is not last

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 114 new commits pushed to the master branch:

• cce8da2: 8268602: a couple runtime/os tests don't check exit code
• da043e9: 8268555: Update HttpClient tests that use ITestContext to jtreg 6+1
• a437ce8: 8268580: runtime/memory/LargePages/TestLargePagesFlags.java should be run in driver mode
• bd9c2fa: 8268565: runtime/records/RedefineRecord.java should be run in driver mode
• e3eef3b: 8268576: jdk/jfr/event/gc/collection/TestSystemGc.java fails
• 7b2e7d8: 8268525: Some new memory leak after JDK-8248268 and JDK-8255557
• 53b6e2c: 8267448: Add "ulimit -a" to environment.html
• 5b8c51f: 8268539: several serviceability/sa tests should be run in driver mode
• 7400789: 8268542: serviceability/logging/TestFullNames.java tests only 1st test case
• a95e64c: 8268443: ParallelGC Full GC should use parallel WeakProcessor
• ... and 104 more: https://git.openjdk.java.net/jdk17/compare/908aca29ca60f5f251df8c6a31b2543929be12fc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

Going to push as commit abe20c1.
Since your change was applied there have been 119 commits pushed to the master branch:

• b318535: 8267579: Thread::cooked_allocated_bytes() hits assert(left >= right) failed: avoid underflow
• fe48ea9: 8268342: java/foreign/channels/TestAsyncSocketChannels.java fails with "IllegalStateException: This segment is already closed"
• 6171ae4: 8268630: ProblemList serviceability/jvmti/CompiledMethodLoad/Zombie.java on linux-aarch64
• 01054e6: 8268470: CDS dynamic dump asserts with JFR RecordingStream
• e39346e: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
• cce8da2: 8268602: a couple runtime/os tests don't check exit code
• da043e9: 8268555: Update HttpClient tests that use ITestContext to jtreg 6+1
• a437ce8: 8268580: runtime/memory/LargePages/TestLargePagesFlags.java should be run in driver mode
• bd9c2fa: 8268565: runtime/records/RedefineRecord.java should be run in driver mode
• e3eef3b: 8268576: jdk/jfr/event/gc/collection/TestSystemGc.java fails
• ... and 109 more: https://git.openjdk.java.net/jdk17/compare/908aca29ca60f5f251df8c6a31b2543929be12fc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit abe20c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.