Skip to content
This repository has been archived by the owner. It is now read-only.

8270908: TestParallelRefProc fails on single core machines #262

Conversation

mychris
Copy link
Member

@mychris mychris commented Jul 21, 2021

Hi,

please review this small fix for the test case TestParallelRefProc.
I changed the way the ParallelGC is tested to the same way G1GC is tested, since the test failed on single core machines. Ergo configures only 1 parallel GC thread on single core machines and with only 1 thread, ergo does not enable ParallelRefProcEnabled.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270908: TestParallelRefProc fails on single core machines

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/262/head:pull/262
$ git checkout pull/262

Update a local copy of the PR:
$ git checkout pull/262
$ git pull https://git.openjdk.java.net/jdk17 pull/262/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 262

View PR using the GUI difftool:
$ git pr show -t 262

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/262.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 21, 2021

👋 Welcome back cgo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8270908: TestParallelRefProc fails on single core machine 8270908: TestParallelRefProc fails on single core machines Jul 21, 2021
@openjdk openjdk bot added the rfr label Jul 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@mychris The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Jul 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 21, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Thanks! Lgtm.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@mychris This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270908: TestParallelRefProc fails on single core machines

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • e3800e6: 8271162: runtime/StackTrace/LargeClassTest.java can be run in driver mode
  • ee93cef: 8271158: runtime/handshake/HandshakeTimeoutTest.java test doesn't check exit code
  • 84be910: 8271169: runtime/Safepoint/TestAbortVMOnSafepointTimeout.java can be run in driver mode
  • 2d165a2: 8271160: runtime/jni/checked/TestCheckedJniExceptionCheck.java doesn't set -Djava.library.path
  • 7165b3f: 8271155: Wrong path separator in env variable
  • ecc37b0: 8270916: Update java.lang.annotation.Target for changes in JLS 9.6.4.1
  • 4812e53: 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code
  • 6a9ab6a: 8271093: remove deadcode from runtime/Thread/TestThreadDumpSMRInfo.java test
  • e7f9009: 8270085: Suspend during block transition may deadlock if lock held
  • 39b486d: 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java
  • ... and 20 more: https://git.openjdk.java.net/jdk17/compare/61359c46a74b03b94738744d309334a5af162f08...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @kimbarrett) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jul 21, 2021
Copy link
Contributor

@kimbarrett kimbarrett left a comment

Looks good.

@mychris
Copy link
Member Author

@mychris mychris commented Jul 23, 2021

Thanks for the reviews.
The test failure on macOS is because 3 unrelated test cases ran into a timeout:

  • runtime/CreateMirror/ArraysNewInstanceBug.java
  • runtime/exceptionMsgs/ArrayIndexOutOfBoundsException/ArrayIndexOutOfBoundsExceptionTest.java#id1
  • runtime/LoadClass/TestResize.java

/integrate

@openjdk openjdk bot added the sponsor label Jul 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

@mychris
Your change (at version b31b5a6) is now ready to be sponsored by a Committer.

@mychris
Copy link
Member Author

@mychris mychris commented Jul 28, 2021

@tschatzl or @kimbarrett, would one of you mind sponsoring this change?

@kimbarrett
Copy link
Contributor

@kimbarrett kimbarrett commented Jul 28, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

Going to push as commit 6e1da64.
Since your change was applied there have been 41 commits pushed to the master branch:

  • f1e15c8: 8271350: runtime/Safepoint tests use OutputAnalyzer::shouldMatch instead of shouldContaint
  • fbe28e4: 8270866: NPE in DocTreePath.getTreePath()
  • f662127: 8270491: SEGV at read_string_field(oopDesc*, char const*, JavaThread*)+0x54
  • cea7bc2: 8271223: two runtime/ClassFile tests don't check exit code
  • b76a838: 8269150: UnicodeReader not translating \u005c\u005d to \]
  • 7ddabbf: 8271175: runtime/jni/FindClassUtf8/FindClassUtf8.java doesn't have to be run in othervm
  • 3c27f91: 8271222: two runtime/Monitor tests don't check exit code
  • 049b2ad: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu
  • 8adf008: 8269984: [macos] JTabbedPane title looks like disabled
  • e90ed6c: 8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code
  • ... and 31 more: https://git.openjdk.java.net/jdk17/compare/61359c46a74b03b94738744d309334a5af162f08...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@kimbarrett @mychris Pushed as commit 6e1da64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-gc integrated
3 participants