Skip to content
This repository has been archived by the owner. It is now read-only.

8271070: ProblemList 3 client tests on Linux-X64 #263

Closed
wants to merge 1 commit into from
Closed

8271070: ProblemList 3 client tests on Linux-X64 #263

wants to merge 1 commit into from

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jul 21, 2021

A trivial fix to ProblemList:

javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java
java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
java/awt/image/multiresolution/MultiresolutionIconTest.java

on Linux-X64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/263/head:pull/263
$ git checkout pull/263

Update a local copy of the PR:
$ git checkout pull/263
$ git pull https://git.openjdk.java.net/jdk17 pull/263/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 263

View PR using the GUI difftool:
$ git pr show -t 263

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/263.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jul 21, 2021

/label add client

Loading

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jul 21, 2021

/label add hotspot-runtime

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 21, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@dcubed-ojdk The label client is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • 2d
  • swing
  • hotspot-runtime
  • jmx
  • nio
  • build
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

Loading

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jul 21, 2021

/label add awt
/label add swing

Loading

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Jul 21, 2021
@openjdk openjdk bot added the awt label Jul 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@dcubed-ojdk
The awt label was successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@dcubed-ojdk
The swing label was successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 21, 2021

Webrevs

Loading

prrace
prrace approved these changes Jul 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271070: ProblemList 3 client tests on Linux-X64

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 21, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jul 21, 2021

@prrace - Thanks for the fast review!

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

Going to push as commit 08c52fd.

Loading

@openjdk openjdk bot closed this Jul 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@dcubed-ojdk Pushed as commit 08c52fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@dcubed-ojdk dcubed-ojdk deleted the JDK-8271070 branch Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants