8271093: remove deadcode from runtime/Thread/TestThreadDumpSMRInfo.java test

[iignatev]

Hi all,

could you please review this trivial test-only clean-up?
from JBS:

TestThreadDumpSMRInfo::usage isn't used by anyone and should be removed

PS alternatively, TestThreadDumpSMRInfo::usage can be called in an else branch at L70, but I don't see much point in that

Thanks,
-- Igor

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271093: remove deadcode from runtime/Thread/TestThreadDumpSMRInfo.java test

Reviewers

• Jie Fu (@DamonFool - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/265/head:pull/265
$ git checkout pull/265

Update a local copy of the PR:
$ git checkout pull/265
$ git pull https://git.openjdk.java.net/jdk17 pull/265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 265

View PR using the GUI difftool:
$ git pr show -t 265

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/265.diff

[bridgekeeper]

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iignatev The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6b435e96)

[DamonFool]

Hi @iignatev ,

I'm not sure changes like this should go into jdk17 since we are already in RDP2 [1].
Thanks.

[1] https://mail.openjdk.java.net/pipermail/jdk-dev/2021-July/005758.html

[iignatev]

Hi @DamonFool ,

according to JEP3, P1–P5 doc/test bugs are allowed in RDP2[1] and do not require approval. so I don't see any reason why it should not go into jdk17.

Thanks,
-- Igor

[1] https://openjdk.java.net/jeps/3#rdp-2
[2] https://openjdk.java.net/jeps/3#Test-and-documentation-bugs

[DamonFool]

according to JEP3, P1–P5 doc/test bugs are allowed in RDP2[1] and do not require approval. so I don't see any reason why it should not go into jdk17.

Okay, I see.

[DamonFool]

Looks good and trivial.
Thanks.

[openjdk]

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271093: remove deadcode from runtime/Thread/TestThreadDumpSMRInfo.java test

Reviewed-by: jiefu, dholmes, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• e7f9009: 8270085: Suspend during block transition may deadlock if lock held
• 39b486d: 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java
• 4119a52: 8270461: ZGC: Invalid oop passed to ZBarrierSetRuntime::load_barrier_on_oop_array

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

LGTM.

Thanks,
David

[dcubed-ojdk]

Looks good to me also.

I usually have those usage() calls in with the argument processing logic.
The proper place is in an else branch at L70 (as you mentioned). I wonder
if I forgot to do it or if I somehow lost those lines before integrating the
test (so very long ago...).

[dcubed-ojdk]

Thumbs up.

[iignatev]

thank you all for your reviews!

/integrate

[openjdk]

Going to push as commit 6a9ab6a.
Since your change was applied there have been 3 commits pushed to the master branch:

• e7f9009: 8270085: Suspend during block transition may deadlock if lock held
• 39b486d: 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java
• 4119a52: 8270461: ZGC: Invalid oop passed to ZBarrierSetRuntime::load_barrier_on_oop_array

Your commit was automatically rebased without conflicts.

[openjdk]

@iignatev Pushed as commit 6a9ab6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.