8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code

[iignatev]

Hi all,

could you please review this trivial test-only patch that adds a check of the exit code to runtime/duplAttributes/DuplAttributesTest.java test?

Thanks,
-- Igor

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code

Reviewers

• Jie Fu (@DamonFool - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/266/head:pull/266
$ git checkout pull/266

Update a local copy of the PR:
$ git checkout pull/266
$ git pull https://git.openjdk.java.net/jdk17 pull/266/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 266

View PR using the GUI difftool:
$ git pr show -t 266

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/266.diff

[bridgekeeper]

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iignatev The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (493c4e8f)

[DamonFool]

Looks good and trivial.
Thanks.

[openjdk]

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code

Reviewed-by: jiefu, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

LGTM.

Thanks,
David

[iignatev]

David and Jie, thank you for your reviews.

/integrate

[openjdk]

Going to push as commit 4812e53.
Since your change was applied there have been 4 commits pushed to the master branch:

• 6a9ab6a: 8271093: remove deadcode from runtime/Thread/TestThreadDumpSMRInfo.java test
• e7f9009: 8270085: Suspend during block transition may deadlock if lock held
• 39b486d: 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java
• 4119a52: 8270461: ZGC: Invalid oop passed to ZBarrierSetRuntime::load_barrier_on_oop_array

Your commit was automatically rebased without conflicts.

[openjdk]

@iignatev Pushed as commit 4812e53.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.