Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk17 Public archive

8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java #268

Closed
wants to merge 1 commit into from
Closed

8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java #268

wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jul 22, 2021

A trivial fix to ProblemList runtime/InvocationTests/invokevirtualTests.java.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/268/head:pull/268
$ git checkout pull/268

Update a local copy of the PR:
$ git checkout pull/268
$ git pull https://git.openjdk.java.net/jdk17 pull/268/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 268

View PR using the GUI difftool:
$ git pr show -t 268

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/268.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-compiler
/label add hotspot-runtime

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review July 22, 2021 13:41
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

⚠️ @dcubed-ojdk the issue with id 8271126 from commit d1257d54f9352fa84207036d14b764a1244a9545 does not exist in project JDK.

@dcubed-ojdk dcubed-ojdk changed the title Backport d1257d54f9352fa84207036d14b764a1244a9545 XXX Jul 22, 2021
@dcubed-ojdk dcubed-ojdk changed the title XXX Backport d1257d54f9352fa84207036d14b764a1244a9545 Jul 22, 2021
@dcubed-ojdk dcubed-ojdk changed the title Backport d1257d54f9352fa84207036d14b764a1244a9545 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java Jul 22, 2021
@openjdk openjdk bot added rfr Pull request is ready for review hotspot-compiler hotspot-compiler-dev@openjdk.java.net labels Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@dcubed-ojdk dcubed-ojdk changed the title 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java Backport d1257d54f9352fa84207036d14b764a1244a9545 Jul 22, 2021
@openjdk openjdk bot changed the title Backport d1257d54f9352fa84207036d14b764a1244a9545 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport hotspot-runtime hotspot-runtime-dev@openjdk.java.net labels Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the clean label Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 22, 2021
@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

Going to push as commit 39b486d.

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@dcubed-ojdk Pushed as commit 39b486d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jul 22, 2021

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8271126 branch July 23, 2021 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot-compiler hotspot-compiler-dev@openjdk.java.net hotspot-runtime hotspot-runtime-dev@openjdk.java.net integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants