Skip to content
This repository has been archived by the owner. It is now read-only.

8266036: class file for sun.misc.Contended not found #27

Closed
wants to merge 7 commits into from

Conversation

@lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jun 11, 2021

[this is an improved version of openjdk/jdk PR:
https://github.com/openjdk/jdk/pull/4428
]

The ct.sym may contain classfiles referring to annotations that are not present in ct.sym (liek JDK's internal annotation sun.misc.Contended). If javac will try to load them (while discovering annotations for the purpose of detecting which annotation processors should be run), an error will be produced (please see the issue). The proposal is to strip annotations that are not present in ct.sym when generating ct.sym.

As noted by @jddarcy, we also need a special handling of ValueBased, which this patch should do, so it also solves https://bugs.openjdk.java.net/browse/JDK-8258421

/issue JDK-8258421


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8266036: class file for sun.misc.Contended not found
  • JDK-8258421: (jdeprscan) tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java failed with "error: cannot access jdk.internal.ValueBased"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/27/head:pull/27
$ git checkout pull/27

Update a local copy of the PR:
$ git checkout pull/27
$ git pull https://git.openjdk.java.net/jdk17 pull/27/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27

View PR using the GUI difftool:
$ git pr show -t 27

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/27.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 11, 2021

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2021

@lahodaj
Adding additional issue to issue list: 8258421: (jdeprscan) tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java failed with "error: cannot access jdk.internal.ValueBased".

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2021

@lahodaj The following labels will be automatically applied to this pull request:

  • build
  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 11, 2021

Webrevs

Loading

Copy link
Member

@jddarcy jddarcy left a comment

I was wondering how better to document that the addition of new JDK-specific annotation types might require more updates to this list.

Perhaps adding notes in the existing annotation types would help, as people might cut-and-paste the old types when creating new ones. That may be more effective than adding package-level documentation on the internal packages.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2021

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266036: class file for sun.misc.Contended not found
8258421: (jdeprscan) tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java failed with "error: cannot access jdk.internal.ValueBased"

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 73 new commits pushed to the master branch:

  • 820f290: 8268859: jshell throws exception while parsing illegal "case true"
  • 815e4af: 8269802: javac fails to compile nested pattern matching switches
  • 2daf39a: 8269830: SA's vm object vtable matching code sometimes matches on incorrect type
  • 0ebf8aa: 8268778: CDS check_excluded_classes needs DumpTimeTable_lock
  • 0d1cd3a: 8269825: [TESTBUG] Missing testing for x86 KNL platforms
  • e0c130f: 8269955: ProblemList compiler/vectorapi/VectorCastShape[64|128]Test.java tests on x86
  • 1166ef2: 8268966: AArch64: 'bad AD file' in some vector conversion tests
  • 3a69024: 8225667: Clarify the behavior of System::gc w.r.t. reference processing
  • 2b20778: 8269568: JVM crashes when running VectorMask query tests
  • 0f4e07b: 8269661: JNI_GetStringCritical does not lock char array
  • ... and 63 more: https://git.openjdk.java.net/jdk17/compare/44691cc3b003ee6769249b481fb9bf9c5afa6182...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 11, 2021
@lahodaj
Copy link
Contributor Author

@lahodaj lahodaj commented Jun 28, 2021

@jddarcy thanks for the comment, and sorry for delays. I've updated the annotation with a note on the special annotations, as suggested. Does the text make sense? Thanks!

Loading

@lahodaj
Copy link
Contributor Author

@lahodaj lahodaj commented Jul 7, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

Going to push as commit 7fcd5ca.
Since your change was applied there have been 74 commits pushed to the master branch:

  • a49b1dc: 8269772: [macos-aarch64] test compilation failed with "SocketException: No buffer space available"
  • 820f290: 8268859: jshell throws exception while parsing illegal "case true"
  • 815e4af: 8269802: javac fails to compile nested pattern matching switches
  • 2daf39a: 8269830: SA's vm object vtable matching code sometimes matches on incorrect type
  • 0ebf8aa: 8268778: CDS check_excluded_classes needs DumpTimeTable_lock
  • 0d1cd3a: 8269825: [TESTBUG] Missing testing for x86 KNL platforms
  • e0c130f: 8269955: ProblemList compiler/vectorapi/VectorCastShape[64|128]Test.java tests on x86
  • 1166ef2: 8268966: AArch64: 'bad AD file' in some vector conversion tests
  • 3a69024: 8225667: Clarify the behavior of System::gc w.r.t. reference processing
  • 2b20778: 8269568: JVM crashes when running VectorMask query tests
  • ... and 64 more: https://git.openjdk.java.net/jdk17/compare/44691cc3b003ee6769249b481fb9bf9c5afa6182...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@lahodaj Pushed as commit 7fcd5ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants