8271155: Wrong path separator in env variable

[alexeysemenyukoracle]

Replace ";" with FileUtils::pathSeparator in the expression adding 'app' dir to env variable in jpackage app launcher.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271155: Wrong path separator in env variable

Reviewers

• Andy Herrick (@andyherrick - Reviewer)
• Kevin Rushforth (@kevinrushforth - Author)
• Iris Clark (@irisclark - Reviewer)
• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/271/head:pull/271
$ git checkout pull/271

Update a local copy of the PR:
$ git checkout pull/271
$ git pull https://git.openjdk.java.net/jdk17 pull/271/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 271

View PR using the GUI difftool:
$ git pr show -t 271

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/271.diff

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b83bb5a1)

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271155: Wrong path separator in env variable

Reviewed-by: herrick, kcr, iris, almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 141 new commits pushed to the master branch:

• ecc37b0: 8270916: Update java.lang.annotation.Target for changes in JLS 9.6.4.1
• 4812e53: 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code
• 6a9ab6a: 8271093: remove deadcode from runtime/Thread/TestThreadDumpSMRInfo.java test
• e7f9009: 8270085: Suspend during block transition may deadlock if lock held
• 39b486d: 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java
• 4119a52: 8270461: ZGC: Invalid oop passed to ZBarrierSetRuntime::load_barrier_on_oop_array
• 89f7998: 8266347: assert(Dependencies::is_concrete_root_method(fm, ctxk) == Dependencies::is_concrete_method(m, ctxk)) failed: mismatch
• e1051ae: 8264066: Enhance compiler validation
• add995b: 8265201: JarFile.getInputStream not validating invalid signed jars
• ca6b222: 8258432: Improve File Transfers
• ... and 131 more: https://git.openjdk.java.net/jdk17/compare/1404e4bf44e28cadda3949f9e398e664cb98a5e2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinrushforth]

Looks good. Is there a unit test associated with this? If not, do you think one would be useful?

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit 7165b3f.
Since your change was applied there have been 141 commits pushed to the master branch:

• ecc37b0: 8270916: Update java.lang.annotation.Target for changes in JLS 9.6.4.1
• 4812e53: 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code
• 6a9ab6a: 8271093: remove deadcode from runtime/Thread/TestThreadDumpSMRInfo.java test
• e7f9009: 8270085: Suspend during block transition may deadlock if lock held
• 39b486d: 8271126: ProblemList runtime/InvocationTests/invokevirtualTests.java
• 4119a52: 8270461: ZGC: Invalid oop passed to ZBarrierSetRuntime::load_barrier_on_oop_array
• 89f7998: 8266347: assert(Dependencies::is_concrete_root_method(fm, ctxk) == Dependencies::is_concrete_method(m, ctxk)) failed: mismatch
• e1051ae: 8264066: Enhance compiler validation
• add995b: 8265201: JarFile.getInputStream not validating invalid signed jars
• ca6b222: 8258432: Improve File Transfers
• ... and 131 more: https://git.openjdk.java.net/jdk17/compare/1404e4bf44e28cadda3949f9e398e664cb98a5e2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit 7165b3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[alexeysemenyukoracle]

There is no unit test covering this area. I'll file follow up CR to add one in JDK18.

[AlanBateman]

Is there a test planned for this change or is it covered by an existing test? Just asking as this has been committed to openjdk/jdk17 and wondering what the test coverage is.

[kevinrushforth]

Alexey filed JDK-8271170 to cover this.