Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu #272

Closed

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Jul 22, 2021

This test can fail pretty consistently on some slow systems. Increased delay fixes the issue.
We do have similar fix in #260


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/272/head:pull/272
$ git checkout pull/272

Update a local copy of the PR:
$ git checkout pull/272
$ git pull https://git.openjdk.java.net/jdk17 pull/272/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 272

View PR using the GUI difftool:
$ git pr show -t 272

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/272.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2021

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu Jul 22, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@azvegint The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt client-libs-dev@openjdk.java.net label Jul 22, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 22, 2021

Webrevs

@azuev-java
Copy link
Member

azuev-java commented Jul 22, 2021

I am not sure if we supposed to bump up the copyright year or it is supposed to be done with some script later, but i usually do it myself just to be sure.

@azvegint
Copy link
Member Author

azvegint commented Jul 22, 2021

I am not sure if we supposed to bump up the copyright year or it is supposed to be done with some script later, but i usually do it myself just to be sure.

updated

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu

Reviewed-by: kizune, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 8adf008: 8269984: [macos] JTabbedPane title looks like disabled
  • e90ed6c: 8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code
  • b4c6229: 8271189: runtime/handshake/HandshakeTimeoutTest.java can be run in driver mode
  • e3800e6: 8271162: runtime/StackTrace/LargeClassTest.java can be run in driver mode
  • ee93cef: 8271158: runtime/handshake/HandshakeTimeoutTest.java test doesn't check exit code
  • 84be910: 8271169: runtime/Safepoint/TestAbortVMOnSafepointTimeout.java can be run in driver mode
  • 2d165a2: 8271160: runtime/jni/checked/TestCheckedJniExceptionCheck.java doesn't set -Djava.library.path
  • 7165b3f: 8271155: Wrong path separator in env variable
  • ecc37b0: 8270916: Update java.lang.annotation.Target for changes in JLS 9.6.4.1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 22, 2021
@@ -79,10 +79,12 @@ void test() {
frame.setExtendedState(Frame.ICONIFIED);

Util.waitForIdle(robot);
robot.delay(200);
Copy link
Member

@mrserb mrserb Jul 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember some similar issues, so I 'grep" our tests. Looks like usually a bigger delay is used, like 500 or even 1 second.

Copy link
Contributor

@prsadhuk prsadhuk Jul 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we use delay of 1 sec after frame.setvisible and 500ms after events.

Can you also please rectify the wildcard imports? Did you try to give CI job running this test for several iterations in all platforms, if yes, can you post it in JBS?

Copy link
Contributor

@prsadhuk prsadhuk left a comment

Looks good. BTW, normally in swing we also do dispose of the frame after test is over in finally block...Not sure in awt Frame...It may not be required if you are running standalone but in a group of CI run, it might prove effective..

@azvegint
Copy link
Member Author

azvegint commented Jul 23, 2021

Looks good. BTW, normally in swing we also do dispose of the frame after test is over in finally block...Not sure in awt Frame...It may not be required if you are running standalone but in a group of CI run, it might prove effective..

looks like jtreg handles this, but this might be helpful specially for standalone run.

@azvegint
Copy link
Member Author

azvegint commented Jul 23, 2021

CI job run is green.

mrserb
mrserb approved these changes Jul 24, 2021
@azvegint
Copy link
Member Author

azvegint commented Jul 24, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 24, 2021

Going to push as commit 049b2ad.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 8adf008: 8269984: [macos] JTabbedPane title looks like disabled
  • e90ed6c: 8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code
  • b4c6229: 8271189: runtime/handshake/HandshakeTimeoutTest.java can be run in driver mode
  • e3800e6: 8271162: runtime/StackTrace/LargeClassTest.java can be run in driver mode
  • ee93cef: 8271158: runtime/handshake/HandshakeTimeoutTest.java test doesn't check exit code
  • 84be910: 8271169: runtime/Safepoint/TestAbortVMOnSafepointTimeout.java can be run in driver mode
  • 2d165a2: 8271160: runtime/jni/checked/TestCheckedJniExceptionCheck.java doesn't set -Djava.library.path
  • 7165b3f: 8271155: Wrong path separator in env variable
  • ecc37b0: 8270916: Update java.lang.annotation.Target for changes in JLS 9.6.4.1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 24, 2021
@openjdk
Copy link

openjdk bot commented Jul 24, 2021

@azvegint Pushed as commit 049b2ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awt client-libs-dev@openjdk.java.net integrated Pull request has been integrated
4 participants