Skip to content
This repository has been archived by the owner. It is now read-only.

8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code #277

Closed
wants to merge 1 commit into from

Conversation

@iignatev
Copy link
Member

@iignatev iignatev commented Jul 23, 2021

Hi all,

could you please review the patch that adds an exit-code check to serviceability/jvmti/GetObjectSizeClass.java test?

from JBS:

serviceability/jvmti/GetObjectSizeClass.java test spawns a new JVM but doesn't check its exit code which might lead to both type-I and type-II errors

testing: serviceability/jvmti/GetObjectSizeClass.java on {linux,windows,macos}-x64

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/277/head:pull/277
$ git checkout pull/277

Update a local copy of the PR:
$ git checkout pull/277
$ git pull https://git.openjdk.java.net/jdk17 pull/277/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 277

View PR using the GUI difftool:
$ git pr show -t 277

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/277.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 23, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title 8271173 8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code Jul 23, 2021
@openjdk openjdk bot added the rfr label Jul 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

@iignatev The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 23, 2021

Webrevs

Loading

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good and trivial.

Thanks,
David

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • e3800e6: 8271162: runtime/StackTrace/LargeClassTest.java can be run in driver mode
  • ee93cef: 8271158: runtime/handshake/HandshakeTimeoutTest.java test doesn't check exit code
  • 84be910: 8271169: runtime/Safepoint/TestAbortVMOnSafepointTimeout.java can be run in driver mode
  • 2d165a2: 8271160: runtime/jni/checked/TestCheckedJniExceptionCheck.java doesn't set -Djava.library.path
  • 7165b3f: 8271155: Wrong path separator in env variable
  • ecc37b0: 8270916: Update java.lang.annotation.Target for changes in JLS 9.6.4.1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 23, 2021
@iignatev
Copy link
Member Author

@iignatev iignatev commented Jul 23, 2021

Thanks, David.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

Going to push as commit e90ed6c.
Since your change was applied there have been 7 commits pushed to the master branch:

  • b4c6229: 8271189: runtime/handshake/HandshakeTimeoutTest.java can be run in driver mode
  • e3800e6: 8271162: runtime/StackTrace/LargeClassTest.java can be run in driver mode
  • ee93cef: 8271158: runtime/handshake/HandshakeTimeoutTest.java test doesn't check exit code
  • 84be910: 8271169: runtime/Safepoint/TestAbortVMOnSafepointTimeout.java can be run in driver mode
  • 2d165a2: 8271160: runtime/jni/checked/TestCheckedJniExceptionCheck.java doesn't set -Djava.library.path
  • 7165b3f: 8271155: Wrong path separator in env variable
  • ecc37b0: 8270916: Update java.lang.annotation.Target for changes in JLS 9.6.4.1

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

@iignatev Pushed as commit e90ed6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@iignatev iignatev deleted the 8271173 branch Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants