Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk17 Public archive

8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code #284

Closed
wants to merge 2 commits into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Jul 27, 2021

Hi all,

could you please review this small patch?

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/284/head:pull/284
$ git checkout pull/284

Update a local copy of the PR:
$ git checkout pull/284
$ git pull https://git.openjdk.java.net/jdk17 pull/284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 284

View PR using the GUI difftool:
$ git pr show -t 284

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/284.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8271224 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code Jul 27, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 27, 2021
@openjdk
Copy link

openjdk bot commented Jul 27, 2021

@iignatev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.java.net label Jul 27, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 27, 2021

Webrevs

Copy link
Member

@mseledts mseledts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@iignatev
Copy link
Member Author

iignatev commented Aug 3, 2021

closing in favor of openjdk/jdk#4974

@iignatev iignatev closed this Aug 3, 2021
@iignatev iignatev deleted the 8271224 branch August 3, 2021 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.java.net rfr Pull request is ready for review
2 participants