Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk17 Public archive

8271352: Extend jcc erratum mitigation to additional processors #286

Closed
wants to merge 1 commit into from

Conversation

kimbarrett
Copy link
Contributor

@kimbarrett kimbarrett commented Jul 28, 2021

Please review this change to default enable the Intel jcc erratum
performance mitigation for family 6 model 165 (0xA5). This seems to reduce
the frequency of an issue that is still under investigation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271352: Extend jcc erratum mitigation to additional processors

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/286/head:pull/286
$ git checkout pull/286

Update a local copy of the PR:
$ git checkout pull/286
$ git pull https://git.openjdk.java.net/jdk17 pull/286/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 286

View PR using the GUI difftool:
$ git pr show -t 286

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/286.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2021

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 28, 2021
@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.java.net label Jul 28, 2021
@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271352: Extend jcc erratum mitigation to additional processors

Reviewed-by: thartmann, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2021

Webrevs

@kimbarrett
Copy link
Contributor Author

Thanks for reviews @TobiHartmann and @fisk . Currently waiting for jdk17-fix-request approval.

@TobiHartmann
Copy link
Member

And for the record: I think this is a trivial change.

@kimbarrett
Copy link
Contributor Author

Thanks @TobiHartmann - I agree it's a trivial change. It's passed tests and has jdk17-fix approval, so I'm going ahead with pushing now.

@kimbarrett
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 28, 2021

Going to push as commit 5fcf720.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 6e1da64: 8270908: TestParallelRefProc fails on single core machines

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Jul 28, 2021
@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@kimbarrett Pushed as commit 5fcf720.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Jul 28, 2021
@kimbarrett kimbarrett deleted the model_a5 branch August 4, 2021 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot hotspot-dev@openjdk.java.net integrated Pull request has been integrated
3 participants