Skip to content
This repository has been archived by the owner. It is now read-only.

8271412: ProblemList javax/sound/midi/Sequencer/Looping.java #291

Closed
wants to merge 2 commits into from
Closed

8271412: ProblemList javax/sound/midi/Sequencer/Looping.java #291

wants to merge 2 commits into from

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jul 28, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8271412: ProblemList javax/sound/midi/Sequencer/Looping.java
  • JDK-8271413: ProblemList 2 locale tests on macOS-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/291/head:pull/291
$ git checkout pull/291

Update a local copy of the PR:
$ git checkout pull/291
$ git pull https://git.openjdk.java.net/jdk17 pull/291/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 291

View PR using the GUI difftool:
$ git pr show -t 291

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/291.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 28, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@dcubed-ojdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

Loading

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jul 28, 2021

/issue JDK-8271412

/issue JDK-8271413

Loading

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jul 28, 2021

/label add core-libs

/label add sound

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8271413: ProblemList 2 locale tests on macOS-x64.

Loading

@openjdk openjdk bot added the core-libs label Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@dcubed-ojdk
The core-libs label was successfully added.

Loading

@openjdk openjdk bot added the sound label Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@dcubed-ojdk
The sound label was successfully added.

Loading

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Jul 28, 2021
@openjdk openjdk bot added the rfr label Jul 28, 2021
naotoj
naotoj approved these changes Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271412: ProblemList javax/sound/midi/Sequencer/Looping.java
8271413: ProblemList 2 locale tests on macOS-x64

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 28, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jul 28, 2021

@naotoj - Thanks for the fast review!

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 28, 2021

Webrevs

Loading

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jul 28, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

Going to push as commit 7bf72ce.

Loading

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@dcubed-ojdk Pushed as commit 7bf72ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@dcubed-ojdk dcubed-ojdk deleted the JDK-8271412 branch Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants