-
Notifications
You must be signed in to change notification settings - Fork 143
8271412: ProblemList javax/sound/midi/Sequencer/Looping.java #291
Conversation
👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into |
@dcubed-ojdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/issue JDK-8271412 /issue JDK-8271413 |
/label add core-libs /label add sound |
@dcubed-ojdk This issue is referenced in the PR title - it will now be updated. |
@dcubed-ojdk |
@dcubed-ojdk |
@dcubed-ojdk |
@dcubed-ojdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@naotoj - Thanks for the fast review! |
/integrate |
Going to push as commit 7bf72ce. |
@dcubed-ojdk Pushed as commit 7bf72ce. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/291/head:pull/291
$ git checkout pull/291
Update a local copy of the PR:
$ git checkout pull/291
$ git pull https://git.openjdk.java.net/jdk17 pull/291/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 291
View PR using the GUI difftool:
$ git pr show -t 291
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/291.diff