Skip to content
This repository has been archived by the owner. It is now read-only.

8271489: (doc) Clarify Filter Factory example #293

Closed

Conversation

@RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Jul 29, 2021

Improve the clarity of comments in the ObjectInputFilter FilterInThread example.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/293/head:pull/293
$ git checkout pull/293

Update a local copy of the PR:
$ git checkout pull/293
$ git pull https://git.openjdk.java.net/jdk17 pull/293/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 293

View PR using the GUI difftool:
$ git pr show -t 293

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/293.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 29, 2021

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 29, 2021

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Jul 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 29, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 29, 2021

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271489: (doc) Clarify Filter Factory example

Reviewed-by: iris, kcr, naoto, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 29, 2021
naotoj
naotoj approved these changes Jul 29, 2021
bplb
bplb approved these changes Jul 29, 2021
@RogerRiggs
Copy link
Contributor Author

@RogerRiggs RogerRiggs commented Jul 29, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 29, 2021

Going to push as commit 286d313.

Loading

@openjdk openjdk bot closed this Jul 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 29, 2021

@RogerRiggs Pushed as commit 286d313.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants