Skip to content
This repository has been archived by the owner. It is now read-only.

8271512: ProblemList serviceability/sa/sadebugd/DebugdConnectTest.java due to 8270326 #295

Closed

Conversation

@plummercj
Copy link
Contributor

@plummercj plummercj commented Jul 29, 2021

This test currently doesn't fail because it is skipped, but when JDK-8270199 is fixed (which causes SA tests to be erroneously skipped skipped), we will start to see failures due to JDK-8270326, so DebugdConnectTest.java needs to be problem listed before JDK-8270199 is fixed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271512: ProblemList serviceability/sa/sadebugd/DebugdConnectTest.java due to 8270326

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/295/head:pull/295
$ git checkout pull/295

Update a local copy of the PR:
$ git checkout pull/295
$ git pull https://git.openjdk.java.net/jdk17 pull/295/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 295

View PR using the GUI difftool:
$ git pr show -t 295

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/295.diff

@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Jul 29, 2021

/label serviceability

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 29, 2021

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 29, 2021

@plummercj
The serviceability label was successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 29, 2021

Webrevs

Loading

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up. This is a trivial change.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 29, 2021

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271512: ProblemList serviceability/sa/sadebugd/DebugdConnectTest.java due to 8270326

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a1b5b81: 8271507: ProblemList SA tests that are failing with ZGC due to JDK-8248912
  • 286d313: 8271489: (doc) Clarify Filter Factory example

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 29, 2021
@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Jul 30, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

Going to push as commit 6180cf1.
Since your change was applied there have been 2 commits pushed to the master branch:

  • a1b5b81: 8271507: ProblemList SA tests that are failing with ZGC due to JDK-8248912
  • 286d313: 8271489: (doc) Clarify Filter Factory example

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

@plummercj Pushed as commit 6180cf1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants