-
Notifications
You must be signed in to change notification settings - Fork 156
8268525: Some new memory leak after JDK-8248268 and JDK-8255557 #3
Conversation
|
👋 Welcome back weijun! A progress list of the required criteria for merging this PR into |
Webrevs
|
|
Changes look good to me. Thanks for catching these. |
|
@wangweij This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
ascarpino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They look fine
valeriepeng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update looks good.
|
/integrate |
|
Going to push as commit 7b2e7d8.
Your commit was automatically rebased without conflicts. |
Remove newly leaked memory.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/3/head:pull/3$ git checkout pull/3Update a local copy of the PR:
$ git checkout pull/3$ git pull https://git.openjdk.java.net/jdk17 pull/3/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3View PR using the GUI difftool:
$ git pr show -t 3Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/3.diff