Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk17 Public archive

8271588: JFR Recorder Thread crashed with SIGSEGV in write_klass #301

Closed
wants to merge 1 commit into from

Conversation

mgronlun
Copy link
Contributor

@mgronlun mgronlun commented Aug 4, 2021

Greetings,

please help review this fix to better support concurrent class unloading.
Details in the JIRA issue.

Testing: jdk_jfr, stress

Thanks
Markus


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271588: JFR Recorder Thread crashed with SIGSEGV in write_klass

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/301/head:pull/301
$ git checkout pull/301

Update a local copy of the PR:
$ git checkout pull/301
$ git pull https://git.openjdk.java.net/jdk17 pull/301/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 301

View PR using the GUI difftool:
$ git pr show -t 301

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/301.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2021

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 4, 2021
@openjdk
Copy link

openjdk bot commented Aug 4, 2021

@mgronlun The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.java.net label Aug 4, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 4, 2021

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271588: JFR Recorder Thread crashed with SIGSEGV in write_klass

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • cebcc07: 8271894: ProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK17

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 4, 2021
@mgronlun
Copy link
Contributor Author

mgronlun commented Aug 5, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Aug 5, 2021

Going to push as commit 90f85ff.
Since your change was applied there have been 2 commits pushed to the master branch:

  • f312f28: 8271863: ProblemList serviceability/sa/TestJmapCore.java on linux-x64 with ZGC
  • cebcc07: 8271894: ProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK17

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 5, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 5, 2021
@openjdk
Copy link

openjdk bot commented Aug 5, 2021

@mgronlun Pushed as commit 90f85ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.java.net integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants