Skip to content
This repository has been archived by the owner. It is now read-only.

8272472: StackGuardPages test doesn't build with glibc 2.34 #304

Closed
wants to merge 2 commits into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Aug 15, 2021

Please review this simple test fix to address an issue that will prevent the JDK 17 test sources from building on more recent Linux distributions with Glibc 2.34. When building under _GNU_SOURCE the value of SIGSTKSZ is no longer a constant and so cannot be used in an array declaration. The simple fix is to malloc the array instead.

This is a PR against 17 pending a decision as to whether this needs to, and can be, addressed in 17. If not then this PR will be withdrawn and resubmitted against 18 with a backport to 17u.

Testing: local & mach5 tiers 1-3

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272472: StackGuardPages test doesn't build with glibc 2.34

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/304/head:pull/304
$ git checkout pull/304

Update a local copy of the PR:
$ git checkout pull/304
$ git pull https://git.openjdk.java.net/jdk17 pull/304/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 304

View PR using the GUI difftool:
$ git pr show -t 304

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/304.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 15, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 15, 2021

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Aug 15, 2021
@dholmes-ora dholmes-ora marked this pull request as ready for review Aug 16, 2021
@openjdk openjdk bot added the rfr label Aug 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 16, 2021

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

Looks good to me.

I'd like this fix goes into jdk17 since it's a build error and only affects test code.
Thanks.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 16, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272472: StackGuardPages test doesn't build with glibc 2.34

Reviewed-by: jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 16, 2021
@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Aug 16, 2021

This is a PR against 17 pending a decision as to whether this needs to, and can be, addressed in 17. If not then this PR will be withdrawn and resubmitted against 18 with a backport to 17u.

Only P1 issues are candidates in the RC phase. So unless this is a P1 then I think you have to re-target it. It's a pity this test issue didn't come up during RDP1 or RDP2 when test issues of any priority could be fixed without additional approval.

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Aug 16, 2021

Only P1 issues are candidates in the RC phase.

Shall we improve the priority to P1 since it's a build failure?

@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Aug 20, 2021

Re-targetting to JDK 18 and 17u

@dholmes-ora dholmes-ora deleted the 8272472 branch Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-runtime ready rfr
3 participants