8268641: [foreign] assert(allocates2(pc)) failed: not in CodeBuffer memory with ShenandoahGC

[DamonFool]

Hi all,

The following 4 tests failed with -XX:+UseShenandoahGC on x86 (both release and debug VMs).

java/foreign/stackwalk/TestStackWalk.java
java/foreign/valist/VaListTest.java
java/foreign/TestUpcall.java
java/foreign/StdLibTest.java

The reason is that code buffer size for upcall_stub_linkToNative is too small.
To fix the crash, the size has been increased from 1024 to 2048 (note: 1536 is still not enough).

Thanks.
Best regards,
Jie

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268641: [foreign] assert(allocates2(pc)) failed: not in CodeBuffer memory with ShenandoahGC

Reviewers

• Rickard Bäckman (@rickard - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/35/head:pull/35
$ git checkout pull/35

Update a local copy of the PR:
$ git checkout pull/35
$ git pull https://git.openjdk.java.net/jdk17 pull/35/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 35

View PR using the GUI difftool:
$ git pr show -t 35

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/35.diff

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c50eea4f)

[DamonFool]

Could someone help to review this one-line fix?
Thanks.

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268641: [foreign] assert(allocates2(pc)) failed: not in CodeBuffer memory with ShenandoahGC

Reviewed-by: rbackman, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 9f7851b: 8260194: Update the documentation for -Xcheck:jni
• ee03bc6: 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC
• f0f2178: 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on win-x64
• 54f5ffe: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
• 2c7e47e: 8268774: Residual logging output written to STDOUT, not STDERR
• 8ea0606: 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed
• 38dbe05: 8268901: JDK-8268768 missed removing two files
• 9ad19f7: 8256934: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit
• 19f5fab: 8268861: Disable Windows-Aarch64 build in GitHub Actions
• 59de99d: 8267271: Fix gc/arguments/TestNewRatioFlag.java expectedNewSize calculation
• ... and 21 more: https://git.openjdk.java.net/jdk17/compare/6171ae455288a74c4c3dcec6983515db04bdc360...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonFool]

Thanks @rickard for your review.

May I get a second review to finish this issue?
Thanks.

[DamonFool]

Thanks @vnkozlov .
/integrate

[openjdk]

Going to push as commit 112ddb7.
Since your change was applied there have been 31 commits pushed to the master branch:

• 9f7851b: 8260194: Update the documentation for -Xcheck:jni
• ee03bc6: 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC
• f0f2178: 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on win-x64
• 54f5ffe: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
• 2c7e47e: 8268774: Residual logging output written to STDOUT, not STDERR
• 8ea0606: 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed
• 38dbe05: 8268901: JDK-8268768 missed removing two files
• 9ad19f7: 8256934: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit
• 19f5fab: 8268861: Disable Windows-Aarch64 build in GitHub Actions
• 59de99d: 8267271: Fix gc/arguments/TestNewRatioFlag.java expectedNewSize calculation
• ... and 21 more: https://git.openjdk.java.net/jdk17/compare/6171ae455288a74c4c3dcec6983515db04bdc360...master

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool Pushed as commit 112ddb7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.