Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.

Conversation

@iignatev
Copy link
Member

@iignatev iignatev commented Jun 10, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268539: several serviceability/sa tests should be run in driver mode

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/4/head:pull/4
$ git checkout pull/4

Update a local copy of the PR:
$ git checkout pull/4
$ git pull https://git.openjdk.java.net/jdk17 pull/4/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4

View PR using the GUI difftool:
$ git pr show -t 4

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/4.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 78cb6776b6d43b67457993a109719b36ee892d60 8268539: several serviceability/sa tests should be run in driver mode Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

This backport pull request has now been updated with issue from the original commit.

@iignatev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@iignatev The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.java.net label Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268539: several serviceability/sa tests should be run in driver mode

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 10, 2021
@iignatev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 10, 2021

Going to push as commit 5b8c51f.

@openjdk openjdk bot closed this Jun 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@iignatev Pushed as commit 5b8c51f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@iignatev The command integrate can only be used in open pull requests.

@mlbridge
Copy link

mlbridge bot commented Jun 10, 2021

Webrevs

@iignatev iignatev deleted the 8268539 branch June 10, 2021 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated serviceability serviceability-dev@openjdk.java.net

Development

Successfully merging this pull request may close these issues.

1 participant