Skip to content
This repository has been archived by the owner. It is now read-only.

8268353: Test libsvml.so is and is not present in jdk image #47

Closed

Conversation

@PaulSandoz
Copy link
Member

@PaulSandoz PaulSandoz commented Jun 14, 2021

Test that when the jdk.incubator.vector module is present that libsvml.so is present, and test the opposite case.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268353: Test libsvml.so is and is not present in jdk image

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/47/head:pull/47
$ git checkout pull/47

Update a local copy of the PR:
$ git checkout pull/47
$ git pull https://git.openjdk.java.net/jdk17 pull/47/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 47

View PR using the GUI difftool:
$ git pr show -t 47

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/47.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 14, 2021

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 14, 2021

@PaulSandoz The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 14, 2021

Webrevs

Loading

Copy link
Contributor

@sviswa7 sviswa7 left a comment

Looks good to me.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268353: Test libsvml.so is and is not present in jdk image

Reviewed-by: sviswanathan, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • f0f2178: 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on win-x64
  • 54f5ffe: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
  • 2c7e47e: 8268774: Residual logging output written to STDOUT, not STDERR
  • 8ea0606: 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed
  • 38dbe05: 8268901: JDK-8268768 missed removing two files
  • 9ad19f7: 8256934: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live Node limit exceeded limit
  • 19f5fab: 8268861: Disable Windows-Aarch64 build in GitHub Actions
  • 59de99d: 8267271: Fix gc/arguments/TestNewRatioFlag.java expectedNewSize calculation
  • 4d545a1: 8267988: C2: assert(!addp->is_AddP() || addp->in(AddPNode::Base)->is_top() || addp->in(AddPNode::Base) == n->in(AddPNode::Base)) failed: Base pointers must match (addp 1301)
  • b18de6c: 8268851: ProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java on linux-X64
  • ... and 15 more: https://git.openjdk.java.net/jdk17/compare/c088d093e2e73fd0739d9e96f9f5ea67a01ae06c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 16, 2021
Copy link
Member

@DamonFool DamonFool left a comment

The test logic should be changed.

If C2 is absent, libsvml.so would not be generated after JDK-8268643.
Thanks.

Loading

@PaulSandoz
Copy link
Member Author

@PaulSandoz PaulSandoz commented Jun 16, 2021

@DamonFool thanks. I updated the test to require C2. This is not exactly what i want but i think is sufficient for now.

Loading

Copy link
Member

@DamonFool DamonFool left a comment

LGTM
Thanks for your update.

Loading

@PaulSandoz
Copy link
Member Author

@PaulSandoz PaulSandoz commented Jun 17, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2021

Going to push as commit 091bc4a.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 69d01b6: 8249899: jdk/javadoc/tool/InlineTagsWithBraces.java uses @ignore w/o bug-id
  • 7d7bdbe: 8268776: Test ADatagramSocket.java missing /othervm from @run tag
  • 344e3ed: 8268080: java/util/concurrent/forkjoin/AsyncShutdownNow.java fails with java.util.concurrent.RejectedExecutionException
  • 4c9aefd: 8268739: AArch64: Build failure after JDK-8267663
  • 112ddb7: 8268641: [foreign] assert(allocates2(pc)) failed: not in CodeBuffer memory with ShenandoahGC
  • 9f7851b: 8260194: Update the documentation for -Xcheck:jni
  • ee03bc6: 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC
  • f0f2178: 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on win-x64
  • 54f5ffe: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
  • 2c7e47e: 8268774: Residual logging output written to STDOUT, not STDERR
  • ... and 22 more: https://git.openjdk.java.net/jdk17/compare/c088d093e2e73fd0739d9e96f9f5ea67a01ae06c...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jun 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2021

@PaulSandoz Pushed as commit 091bc4a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants